watch: open .gitignore files as utf-8 with permissive fallback#5102
Open
SAY-5 wants to merge 1 commit intoAider-AI:mainfrom
Open
watch: open .gitignore files as utf-8 with permissive fallback#5102SAY-5 wants to merge 1 commit intoAider-AI:mainfrom
SAY-5 wants to merge 1 commit intoAider-AI:mainfrom
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2888.
load_gitignoresopened each.gitignorewith the platform default codec, which on Windows is cp1252..gitignorefiles commonly contain comments or filenames in non-ASCII (or bytes from Unix tooling), so the user's traceback hitsUnicodeDecodeErrorfromcp1252.pyand crashes aider on startup before the file watcher can come up. Open withencoding='utf-8'and fall back toerrors='replace'if the file is genuinely not utf-8 — same shape as the existing source-file decoder in aider/io.py.