fix nested code blocks in file content making filenames of commands#5106
Draft
xurizaemon wants to merge 2 commits intoAider-AI:mainfrom
Draft
fix nested code blocks in file content making filenames of commands#5106xurizaemon wants to merge 2 commits intoAider-AI:mainfrom
xurizaemon wants to merge 2 commits intoAider-AI:mainfrom
Conversation
|
|
When generating files like README.md that contain inner fenced code blocks (e.g. ```bash), the whole-file parser was treating those inner fences as end-of-file-block markers, causing commands like `git clone <repo>` to be used as filenames. Fixes Aider-AI#4225 by tracking inner fence depth: fences with a language specifier are treated as content and increment a depth counter; only a plain closing fence at depth 0 ends the file block.
xurizaemon
changed the title
Author
|
but unrelated tests on my fork fail ... not sure what's up there appreciate @Aider-AI if we can see it run here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully I can get tests to run to repro the issue ...
👋🏼 please authorise CI run @Aider-AI :)
Refs #4225