Support ip based rate limiting for Next.js#1049
Open
timokoessler wants to merge 3 commits into
Open
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
timokoessler
force-pushed
the
nextjs-ip-ratelimiting
branch
from
2e50c96 to
c02dacb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
timokoessler
force-pushed
the
nextjs-ip-ratelimiting
branch
from
cf7e3e4 to
95b6e51
Compare
tomaisthorpe
reviewed
Jun 3, 2026
| }); | ||
|
|
||
| t.test("rate limits requests when NEXT_DEPLOYMENT_ID is set", async (t) => { | ||
| process.env.NEXT_DEPLOYMENT_ID = ""; |
There was a problem hiding this comment.
I think this is fine, but is it not better giving it an actual value here? I think sometimes an empty value could be confused for it not being set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Aikido
⚡ Enhancements
🔧 Refactors
More info