Fix CustomId incorrectly set on link and premium buttons #742
+28
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CustomIdwas defined inDiscordComponentbase class with a defaultGuid.NewGuid()value, causing it to be serialized on link buttons (which use URLs) and premium buttons (which use SKU IDs).Changed
CustomIdto a virtual property inDiscordComponentwithout a default value. Override it withGuid.NewGuid()in the 4 component types that require it:DiscordButtonComponentDiscordBaseSelectComponentDiscordTextInputComponentDiscordFileUploadComponentLink and premium buttons now inherit the base property without default initialization, preventing invalid custom_id serialization.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist:
@Aiko-IT-Systems/discatsharp
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.