S3 Sink update aws sdk to 2.X #572
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
commented
Dec 18, 2025
| .withCredentials(new AWSStaticCredentialsProvider(new BasicAWSCredentials( | ||
| localStackContainer.getAccessKey(), localStackContainer.getSecretKey()))) | ||
| static S3Client createS3Client(final LocalStackContainer localStackContainer) { | ||
| return S3Client.builder() |
Contributor
Author
There was a problem hiding this comment.
remove the use of the aws sdk 1.X client for integration tests.
aindriu-aiven
commented
Dec 18, 2025
| } | ||
|
|
||
| private AmazonS3 createAmazonS3Client(final S3SinkConfig config) { | ||
| final var awsEndpointConfig = newEndpointConfiguration(this.config); |
Contributor
Author
There was a problem hiding this comment.
This is now in S3ClientFactory
aindriu-aiven
commented
Dec 18, 2025
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This has been copied from the S3Source connector, I should just move this to a common place.
aindriu-aiven
commented
Dec 18, 2025
s3-sink-connector/src/test/java/io/aiven/kafka/connect/s3/testutils/BucketAccessor.java
Outdated
Show resolved
Hide resolved
aindriu-aiven
commented
Dec 18, 2025
s3-sink-connector/src/main/java/io/aiven/kafka/connect/s3/config/S3SinkConfig.java
Outdated
Show resolved
Hide resolved
aindriu-aiven
commented
Dec 18, 2025
s3-sink-connector/src/test/java/io/aiven/kafka/connect/s3/S3OutputStreamTest.java
Outdated
Show resolved
Hide resolved
…sting the correct details Signed-off-by: Aindriu Lavelle <[email protected]>
aindriu-aiven
force-pushed
the
aindriu-aiven/update-aws-sdk
branch
3 times, most recently
from
d49ef0e to
d192572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change made to be able to remove the aws 1.x sdk and provide the same functionality in the cutover.
I have not done any work on improving the existing code that can be done in a follow up PR.