fix(postgres): support column casting for multi-row inserts#379
Open
nbarrientos wants to merge 1 commit intoAiven-Open:masterfrom
Open
fix(postgres): support column casting for multi-row inserts#379nbarrientos wants to merge 1 commit intoAiven-Open:masterfrom
nbarrientos wants to merge 1 commit intoAiven-Open:masterfrom
Conversation
Previously, when configuring the sink connector with `insert.mode=multi` for a PostgreSQL database, the parent class `GenericDatabaseDialect` was responsible for generating the multi-row insert SQL. This bypassed the PostgreSQL dialect's specific casting logic (e.g., casting a string to `jsonb` if the column has that type). This patch overrides `buildMultiInsertStatement` within the PostgreSQL dialect. This ensures multi-row inserts now behave consistently with single-row inserts, properly applying all required column casts (by calling `transformColumn`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when configuring the sink connector with
insert.mode=multifor a PostgreSQL database, the parent classGenericDatabaseDialectwas responsible for generating the multi-row insert SQL. This "bypassed" the PostgreSQL dialect's specific casting logic (e.g., casting a string tojsonbif the column has that type).This patch overrides
buildMultiInsertStatementwithin the PostgreSQL dialect. This ensures multi-row inserts now behave consistently with single-row inserts, properly applying all required column casts (by callingtransformColumn).