Make it possible to filter on arbitrary journald fields #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new option, journald_filters, which allows to pass a list of filters of the form <journald_field>=<value>. For a list of available journald fields, see: https://www.freedesktop.org/software/systemd/man/latest/systemd.journal-fields.html
rdunklau
force-pushed
the
add_arbitrary_journald_filters
branch
from
01c9fbe to
ec7f967
Compare
Starting with 2.0.4, the errors module does not expose a tuple of retriable errors: instead there is an attribute on each error type. Making journalpump compatible with both the old and new version is outside the scope of this change, so bound the kafka client version.
rdunklau
force-pushed
the
add_arbitrary_journald_filters
branch
from
6251ad7 to
ef3f172
Compare
Starting with 14.0, some execptions have been deprecated. It is outside the scope of this PR to make journalpump compatbible with both the new and old versions.
Version 2.7.0 made ProxyTimeoutError inherit from the builtin TimeoutError, which requires us to redesign our exception handling. This is outside the scope of this PR, so just bound the version.
Newer ubuntu versions have a stricter apparmor policy for rsyslogd, disable it so that the tests can run.
rdunklau
force-pushed
the
add_arbitrary_journald_filters
branch
from
b2b71f2 to
68a884a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new option, journald_filters, which allows to pass a list of filters of the form <journald_field>=.
For a list of available journald fields, see:
https://www.freedesktop.org/software/systemd/man/latest/systemd.journal-fields.html