backups: Handle transiently incorrect partition count #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
aiven-anton/handle-transiently-incorrect-partition-count-on-topic-creation
branch
2 times, most recently
from
7376f34 to
d7c04f5
Compare
When using the backups library to restore topics on KRaft, we are observing the partition count check failing. Subsequent manual checks of the partition count shows the correct count. This commit adds a fix to make the restoration process anticipate that partition count metadata will be initially incorrect but eventually converge on the correct value.
aiven-anton
force-pushed
the
aiven-anton/handle-transiently-incorrect-partition-count-on-topic-creation
branch
from
d7c04f5 to
975df44
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the backups library to restore topics on KRaft, we are observing the partition count check failing. Subsequent manual checks of the partition count shows the correct count. This commit adds a fix to make the restoration process anticipate that partition count metadata will be initially incorrect but eventually converge on the correct value.