Added kafka client id #1105
Open
Added kafka client id #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markretallack Thanks for the pr. Will come back to it soon. |
|
@markretallack can you add a test for client id ? |
muralibasani
force-pushed
the
add-kafka-client-id
branch
from
e61e961 to
465509a
Compare
|
Hi @markretallack do you still need that test? Just looking at where the test would be placed, would tests/integration/conftest.py be the best place to start? |
…ce into add-kafka-client-id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
This change adds in the Kafka client ID to the Kafka producer. It also adds it to the Kafka Admin.
This is needed to allow the client id to be specified, allowing the difference instances to have different names etc...
This does not fix any issue.
Why this way
We needed to be able to specify the actual client id so that we can see the connection appearing from the logs. We also use Kafka rest with a non-standard Kafka, that uses the client ID to specific additional client specific handling.