Skip to content

Conversation

@muralibasani
Copy link
Contributor

@muralibasani muralibasani commented Oct 6, 2025

About this change - What it does

Under benchmarks dir, we have new scripts which

  • creates 100 topics
  • produces 50k messages over rest proxy
  • consumes 50k messages over rest proxy
  • Writes results to a csv file

Added results for karapace 4 and 5 versions.

References: #xxxxx

Why this way

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace/core/coordinator
  schema_coordinator.py
Project Total  

This report was generated by python-coverage-comment-action

@muralibasani muralibasani marked this pull request as ready for review October 10, 2025 12:25
@muralibasani muralibasani requested a review from a team as a code owner October 10, 2025 12:25
@muralibasani muralibasani requested a review from nosahama October 10, 2025 12:25
@muralibasani muralibasani force-pushed the add-benchmarks branch 2 times, most recently from cd39bc5 to 548080c Compare October 16, 2025 14:11
@nosahama
Copy link
Contributor

Ideally there should be no difference in performance between rest-proxy v4 and v5 as majority of the code changes were for SR, but then rest-proxy uses schema-registry and that implementation changed.
While i still review the PR, I start to now suspect all the logic we have loaded the API middleware with, content-type checks, authentication, telemetry, all those will definitely add "slight" (needs verification) latency.

@muralibasani
Copy link
Contributor Author

Ideally there should be no difference in performance between rest-proxy v4 and v5 as majority of the code changes were for SR, but then rest-proxy uses schema-registry and that implementation changed. While i still review the PR, I start to now suspect all the logic we have loaded the API middleware with, content-type checks, authentication, telemetry, all those will definitely add "slight" (needs verification) latency.

@nosahama can you may be also run these scripts on your pc for 4 and 5 versions, just to compare?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants