common: make PersistedProgress._lock a private attribute #641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Makes the
_lock
member ofPersistedProgress
into a Pydantic private attribute. This means it'll be excluded from (de)serialization.This fixes the following problem on Pydantic 2.10.6, Python 3.12.3:
Why this way
This seems like the correct way to specify an attribute that isn't a field, should be excluded from serialization, and initialised by a
default_factory
according to https://docs.pydantic.dev/latest/concepts/models/#private-model-attributes