test: old version builds#32
Closed
Akemi wants to merge 6 commits into
Closed
Conversation
using the oldest xcode toolchain will test some code paths that weren't previously tested, eg older SDK and swift versions.
Owner
Author
|
|
Akemi
force-pushed
the
mac_old_ver_builds
branch
4 times, most recently
from
bec4c18 to
36c1674
Compare
with commit 8d20b72 and PR mpv-player#15442 we switched to the recommended swiftc compiler for building our swift code. this lead to some incompatibilities with swift versions prior to 5.8, where a new linker was introduced. work around that problem by using the old swift frontend build for older swift versions. this can be removed when we remove the support for those old versions. Fixes mpv-player#15591
currently we use the withLock function with NSCondition and NSLock, which are not available on swift versions lower than 5.7. we only added compatibility fallbacks for NSCondition though. introduced in 1364c80 and mpv-player#14334. instead of only adding the fallback to a specific class add it to the whole protocol all the locking classes use, similar to the actual implementation.
UniformTypeIdentifiers is only available since macOS 11. added in 6b0e4f7 and mpv-player#15859. guard the allowedContentTypes UTType property of the NSOpenPanel and add a dummy struct UTType and dummy allowedContentTypes property on macOS versions that don't have those available.
Akemi
force-pushed
the
mac_old_ver_builds
branch
2 times, most recently
from
00424fe to
209cb94
Compare
|
Download the artifacts for this pull request: Windows |
Akemi
force-pushed
the
mac_old_ver_builds
branch
3 times, most recently
from
afce6e0 to
1f10595
Compare
Akemi
force-pushed
the
mac_old_ver_builds
branch
from
1f10595 to
50670cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests