Skip to content

fix: use Solid server runtime imports#7

Merged
Akin01 merged 1 commit into
mainfrom
fix/solid-web-server-runtime
Jun 26, 2026
Merged

fix: use Solid server runtime imports#7
Akin01 merged 1 commit into
mainfrom
fix/solid-web-server-runtime

Conversation

@Akin01

@Akin01 Akin01 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Compile the component package against solid-js/web/dist/server.js so generated SSR helpers do not resolve through the generic solid-js/web entrypoint.
  • Import server-only helpers (ssr, Dynamic) from the server runtime in package source.
  • Add an e2e regression that imports and renders @akin01/solid-email with --conditions=browser.

Fixes #6.

Verification

  • pnpm --filter @solid-email/render --filter @akin01/solid-email run build
  • pnpm --filter @solid-email/render --filter @akin01/solid-email run test
  • pnpm --filter @solid-email/render --filter @akin01/solid-email run typecheck
  • pnpm exec biome check e2e/integrations.e2e.spec.ts packages/solid-email/tsdown.config.ts packages/render/src/shared/slots.ts packages/render/src/shared/solid-js-web-server.d.ts packages/solid-email/src/components/heading/heading.tsx packages/solid-email/src/components/tailwind/tailwind.tsx packages/solid-email/src/render-shim.d.ts
  • pnpm test:e2e
  • pnpm typecheck:e2e

@Akin01 Akin01 changed the title Fix Solid server runtime imports under browser conditions fix: use Solid server runtime imports Jun 26, 2026
@Akin01
Akin01 force-pushed the fix/solid-web-server-runtime branch from ed8fd1a to 2ae4755 Compare June 26, 2026 22:36
@Akin01
Akin01 merged commit 86d44b9 into main Jun 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@akin01/solid-email import fails in Vite dev: ssrStyleProperty missing from solid-js/web dev build

1 participant