Add Apple Accelerate Sparse Solver Support for Apple Silicon Builds#67
Open
GrantHecht wants to merge 7 commits into
Open
Add Apple Accelerate Sparse Solver Support for Apple Silicon Builds#67GrantHecht wants to merge 7 commits into
GrantHecht wants to merge 7 commits into
Conversation
… correct MPL license comment in AccelerateInterface.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Apple Accelerate Sparse solver support for building on newer Apple Silicon ARM CPUs. I spoke with @jbpezent about implementing this a year or so ago after wanting to use ASSET on my M1 Pro Mac, and finally found the time to finish setting it up.
The bulk of the updates are within the new AccelerateInterface.h header, which is heavily based on Eigen's AccelerateSupport module (similar to PardisoInterface.h), but there are some other changes throughout the code to handle which interface is used (controlled via the new USE_ACCELERATE_SPARSE macro that the build system will define if building on a Mac). I also made some minor changes to properly support ARM NEON vectorization (with 128-bit registers).
All of the Python unit tests pass, and I've verified that I'm able to run all of the Python examples successfully (i.e., all converge to solutions) on my MacBook Pro with the M1 Pro CPU.