Skip to content

Conversation

@rmenner
Copy link
Contributor

@rmenner rmenner commented Jul 1, 2025

Resolves AlaskaAirlines/WebCoreStyleSheets#245 Created via auro cli migration tool.

Testing

Design approved ✅

Summary by Sourcery

Update demo HTML pages to align with revised CSS class utilization and theming structure for wcss.

Enhancements:

  • Revise page titles to reflect "Demo" context for auro-accordion.
  • Replace existing token stylesheet links with structured includes for Prism.js, legacy design tokens, and Alaska theme.
  • Add Webcore Stylesheet Alaska theme bundle and retain demo-specific stylesheet references.
  • Add comments clarifying legacy token usage and include minified CSS files.

@rmenner rmenner self-assigned this Jul 1, 2025
@rmenner rmenner requested a review from a team as a code owner July 1, 2025 02:50
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 1, 2025

Reviewer's Guide

Refactored demo HTML to update titles, enhance head section documentation, and replace CSS imports with legacy and theme-specific minified token and webcore stylesheet references.

File-Level Changes

Change Details Files
Updated HTML page titles for consistency
  • Replaced generator-focused title with demo-oriented title
  • Standardized title element text across demo files
demo/api.html
demo/index.html
Reorganized and documented CSS link imports
  • Inserted comments before each stylesheet block (Prism.js, legacy tokens, theme tokens, webcore, demo-specific)
  • Standardized link tag attributes and structure
demo/api.html
demo/index.html
Replaced CSS imports with legacy, theme-specific, and bundled stylesheet references
  • Switched design token paths to legacy and themes/alaska minified CSSCustomProperties
  • Added webcorestylesheets Alaska theme bundle import
  • Removed old unminified CSSCustomProperties links
demo/api.html
demo/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes - here's some feedback:

  • Consider extracting the repeated head section into a shared template or partial to reduce duplication across both demo files.
  • Pin design token and webcore stylesheet versions explicitly instead of using @latest to avoid unexpected breaking changes in downstream consumers.
  • Add Subresource Integrity (SRI) attributes to the external CDN link tags to improve security and ensure the resources haven't been tampered with.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the repeated head section into a shared template or partial to reduce duplication across both demo files.
- Pin design token and webcore stylesheet versions explicitly instead of using @latest to avoid unexpected breaking changes in downstream consumers.
- Add Subresource Integrity (SRI) attributes to the external CDN link tags to improve security and ensure the resources haven't been tampered with.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

Surge demo deployment failed! 😭

@chrisfalaska chrisfalaska force-pushed the migration/fonts/wcss-type-classes branch from 97b85bc to c6d18e4 Compare July 30, 2025 16:17
@chrisfalaska chrisfalaska force-pushed the migration/fonts/wcss-type-classes branch from c6d18e4 to a551f21 Compare July 30, 2025 19:33
@chrisfalaska chrisfalaska force-pushed the migration/fonts/wcss-type-classes branch from a551f21 to e429a9b Compare July 30, 2025 22:43
@chrisfalaska chrisfalaska force-pushed the migration/fonts/wcss-type-classes branch from 0c2fd5c to 3f0787d Compare July 31, 2025 17:22
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something I see in the DOM that is a little confusing. The button in which the trigger text is contained in has body-default class on it, but the trigger slot ends up having heading-2xs on it. I think the heading class is being applied, but it's hard to tell without digging deep into the DOM.

Happy to jump on a call if we need to look at it together.

Screenshot 2025-07-31 at 11 01 15 AM Screenshot 2025-07-31 at 11 01 39 AM

@chrisfalaska
Copy link
Contributor

There is something I see in the DOM that is a little confusing. The button in which the trigger text is contained in has body-default class on it, but the trigger slot ends up having heading-2xs on it. I think the heading class is being applied, but it's hard to tell without digging deep into the DOM.

Happy to jump on a call if we need to look at it together.

Screenshot 2025-07-31 at 11 01 15 AM Screenshot 2025-07-31 at 11 01 39 AM

That DOM deep-digging has been a challenge in general with this component. The body-default is coming from the auro-button component default and the slot classes are coming form Accordion:

const triggerSlotClass = this.variant === 'sm' ? 'body-default' : this.variant === 'lg' ? 'heading-xs' : 'heading-2xs';

@DukeFerdinand DukeFerdinand merged commit 71c7f55 into main Jul 31, 2025
6 of 7 checks passed
@DukeFerdinand DukeFerdinand deleted the migration/fonts/wcss-type-classes branch July 31, 2025 20:36
@blackfalcon
Copy link
Member

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Completed work has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update component font class utilization

7 participants