-
Notifications
You must be signed in to change notification settings - Fork 2
Update wcss type class utilization #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefactored demo HTML to update titles, enhance head section documentation, and replace CSS imports with legacy and theme-specific minified token and webcore stylesheet references. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
- Consider extracting the repeated head section into a shared template or partial to reduce duplication across both demo files.
- Pin design token and webcore stylesheet versions explicitly instead of using @latest to avoid unexpected breaking changes in downstream consumers.
- Add Subresource Integrity (SRI) attributes to the external CDN link tags to improve security and ensure the resources haven't been tampered with.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the repeated head section into a shared template or partial to reduce duplication across both demo files.
- Pin design token and webcore stylesheet versions explicitly instead of using @latest to avoid unexpected breaking changes in downstream consumers.
- Add Subresource Integrity (SRI) attributes to the external CDN link tags to improve security and ensure the resources haven't been tampered with.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Surge demo deployment failed! 😭 |
97b85bc to
c6d18e4
Compare
c6d18e4 to
a551f21
Compare
a551f21 to
e429a9b
Compare
0c2fd5c to
3f0787d
Compare
jordanjones243
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is something I see in the DOM that is a little confusing. The button in which the trigger text is contained in has body-default class on it, but the trigger slot ends up having heading-2xs on it. I think the heading class is being applied, but it's hard to tell without digging deep into the DOM.
Happy to jump on a call if we need to look at it together.
That DOM deep-digging has been a challenge in general with this component. The |
|
🎉 This PR is included in version 5.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |


Resolves AlaskaAirlines/WebCoreStyleSheets#245 Created via auro cli migration tool.
Testing
Design approved ✅
Summary by Sourcery
Update demo HTML pages to align with revised CSS class utilization and theming structure for wcss.
Enhancements: