Skip to content

Conversation

@sun-mota
Copy link
Member

@sun-mota sun-mota commented Sep 25, 2025

Alaska Airlines Pull Request

  1. remove on large emphasis accordion to match to design spec https://www.figma.com/design/VpUz89Ov6ImBpY5YvzYbZW/Auro-toolkit?node-id=11753-19436&m=dev
Before After
image image
  1. remove on right chevron accordion (but add margin to align with content)
Before After
image image

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Remove left-padding from accordion triggers and switch right-chevron variant to use margin for alignment

Enhancements:

  • Replace padding-left with margin-left on right-chevron accordion triggers to align with content
  • Remove left-padding on large emphasis accordion triggers and content wrapper

Summary by Sourcery

Remove left-padding on accordion triggers and update right-chevron variant alignment to match design specifications

Enhancements:

  • Remove left-padding from contentWrapper and trigger on large emphasis accordions
  • Switch right-chevron accordion variant from padding-left to margin-left for correct alignment

@sun-mota sun-mota self-assigned this Sep 25, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 25, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the accordion styles to remove design-inconsistent left-padding from triggers and wrapper, and switches the right-chevron variant to use margin for content alignment.

File-Level Changes

Change Details Files
Remove left-padding from accordion content wrappers and large-emphasis triggers
  • Set default contentWrapper padding-left to 0
  • Delete legacy large-emphasis padding block for triggers and wrapper
src/styles/style.scss
Replace left-padding with margin-left for right-chevron triggers
  • Remove padding-left on right-chevron slotted triggers
  • Remove padding-left on right-chevron contentWrapper
  • Add margin-left to align triggers and wrapper with content
src/styles/style.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

Surge demo deployment failed! 😭

@sun-mota sun-mota force-pushed the sunMota/fix/emphasis-large-right-chevron branch from 8064a81 to ffab2cc Compare September 25, 2025 18:41
@sun-mota sun-mota changed the title fix: remove left-padding on triggers fix: remove left-padding on trigger Sep 25, 2025
@sun-mota sun-mota force-pushed the sunMota/fix/emphasis-large-right-chevron branch from ffab2cc to f0d783e Compare September 25, 2025 19:20
@sun-mota sun-mota marked this pull request as ready for review September 25, 2025 19:21
@sun-mota sun-mota requested a review from a team as a code owner September 25, 2025 19:21
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rmenner rmenner merged commit 6e16e79 into main Sep 29, 2025
6 of 7 checks passed
@rmenner rmenner deleted the sunMota/fix/emphasis-large-right-chevron branch September 29, 2025 17:00
@blackfalcon
Copy link
Member

🎉 This PR is included in version 5.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Completed work has been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trigger has more left-padding with right chevron & emphasis Padding-left styles still present in chevron="right" state

5 participants