-
Notifications
You must be signed in to change notification settings - Fork 2
AURO MIGRATION: Sync templates #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideUpdates the default pull request template to align with Auro migration standards by renaming the checklist section and adding a collapsible, detailed RC testing checklist that covers browser, scenario, and framework validation steps. Flow diagram for contributor steps using the new PR template and RC checklistflowchart TD
A["Start: Contributor opens new pull request form"] --> B["Read contribution summary and guidance"]
B --> C["Fill out 'Review Checklist'"]
C --> C1{"Does the change require release candidate (RC) testing?"}
C1 -- "Yes" --> D["Expand 'RC Checklist' details section"]
C1 -- "No" --> H["Confirm Apache 2.0 license statement"]
D --> E["Perform browser testing on Android, iOS, and desktop as listed"]
E --> F["Validate scenarios and linked issues with reporting team"]
F --> G["Validate frameworks in Auro framework playground (Next React, SvelteKit)"]
G --> H["Confirm Apache 2.0 license statement"]
H --> I["Submit pull request for review"]
I --> J["End"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The hard-coded links to the dev demo (auro-accordion) and the framework playground feel very component-specific; consider parameterizing or generalizing these so the template works correctly across different repos.
- The label 'Next React' in the framework playground section is a bit ambiguous; consider renaming it to something clearer like 'Next.js (React)' to avoid confusion for contributors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hard-coded links to the dev demo (auro-accordion) and the framework playground feel very component-specific; consider parameterizing or generalizing these so the template works correctly across different repos.
- The label 'Next React' in the framework playground section is a bit ambiguous; consider renaming it to something clearer like 'Next.js (React)' to avoid confusion for contributors.
## Individual Comments
### Comment 1
<location> `.github/PULL_REQUEST_TEMPLATE.md:43` </location>
<code_context>
+
+### Scenarios
+
+- [ ] Validated linked issues with issue reporting team
+- [ ] Test coverage report review
+
</code_context>
<issue_to_address>
**suggestion (typo):** Consider adding "the" for smoother grammar in this checklist item.
For example: "Validated linked issues with the issue reporting team."
```suggestion
- [ ] Validated linked issues with the issue reporting team
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
🚀 PR Release Published! To install: npm install @aurodesignsystem-dev/[email protected]Install via alias: npm install @aurodesignsystem/auro-accordion@npm:@aurodesignsystem-dev/[email protected] |
688131f to
57b907d
Compare
57b907d to
a98a3df
Compare
No description provided.