Skip to content

Conversation

@rmenner
Copy link
Contributor

@rmenner rmenner commented Nov 21, 2025

No description provided.

@rmenner rmenner requested a review from a team as a code owner November 21, 2025 19:55
@rmenner rmenner self-assigned this Nov 21, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 21, 2025

Reviewer's Guide

Updates the default pull request template to align with Auro migration standards by renaming the checklist section and adding a collapsible, detailed RC testing checklist that covers browser, scenario, and framework validation steps.

Flow diagram for contributor steps using the new PR template and RC checklist

flowchart TD
  A["Start: Contributor opens new pull request form"] --> B["Read contribution summary and guidance"]
  B --> C["Fill out 'Review Checklist'"]
  C --> C1{"Does the change require release candidate (RC) testing?"}
  C1 -- "Yes" --> D["Expand 'RC Checklist' details section"]
  C1 -- "No" --> H["Confirm Apache 2.0 license statement"]
  D --> E["Perform browser testing on Android, iOS, and desktop as listed"]
  E --> F["Validate scenarios and linked issues with reporting team"]
  F --> G["Validate frameworks in Auro framework playground (Next React, SvelteKit)"]
  G --> H["Confirm Apache 2.0 license statement"]
  H --> I["Submit pull request for review"]
  I --> J["End"]
Loading

File-Level Changes

Change Details Files
Renamed and expanded the PR checklist to include a detailed, collapsible RC testing checklist.
  • Rename the generic 'Checklist' section header to 'Review Checklist' to clarify its purpose for reviewers.
  • Add a collapsible 'RC Checklist' details section that introduces structured testing expectations.
  • Within the RC Checklist, document browser testing requirements across Android, iOS, and desktop with specific browsers to verify.
  • Include scenario validation items for linked issue verification and test coverage review.
  • Reference external resources such as the Browsers Support Guide, dev demo link, and framework playground to guide testers through validation in different environments.
.github/PULL_REQUEST_TEMPLATE.md
Minor formatting cleanup at the end of the template for consistency.
  • Remove an unnecessary HTML line break from the closing thank-you note for cleaner markdown formatting.
  • Preserve existing licensing confirmation and project messaging while aligning formatting with Auro template conventions.
.github/PULL_REQUEST_TEMPLATE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The hard-coded links to the dev demo (auro-accordion) and the framework playground feel very component-specific; consider parameterizing or generalizing these so the template works correctly across different repos.
  • The label 'Next React' in the framework playground section is a bit ambiguous; consider renaming it to something clearer like 'Next.js (React)' to avoid confusion for contributors.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The hard-coded links to the dev demo (auro-accordion) and the framework playground feel very component-specific; consider parameterizing or generalizing these so the template works correctly across different repos.
- The label 'Next React' in the framework playground section is a bit ambiguous; consider renaming it to something clearer like 'Next.js (React)' to avoid confusion for contributors.

## Individual Comments

### Comment 1
<location> `.github/PULL_REQUEST_TEMPLATE.md:43` </location>
<code_context>
+
+### Scenarios
+
+- [ ] Validated linked issues with issue reporting team
+- [ ] Test coverage report review
+
</code_context>

<issue_to_address>
**suggestion (typo):** Consider adding "the" for smoother grammar in this checklist item.

For example: "Validated linked issues with the issue reporting team."

```suggestion
- [ ] Validated linked issues with the issue reporting team
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🚀 PR Release Published! v0.0.0-pr215.3

To install:

npm install @aurodesignsystem-dev/[email protected]

Install via alias:

npm install @aurodesignsystem/auro-accordion@npm:@aurodesignsystem-dev/[email protected]

View on npmjs.com

@rmenner rmenner force-pushed the chore/migration-template-update-reusable branch 2 times, most recently from 688131f to 57b907d Compare November 21, 2025 21:46
@rmenner rmenner force-pushed the chore/migration-template-update-reusable branch from 57b907d to a98a3df Compare November 22, 2025 00:37
@rmenner rmenner merged commit c36acc4 into dev Nov 22, 2025
15 of 18 checks passed
@rmenner rmenner deleted the chore/migration-template-update-reusable branch November 22, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants