-
Notifications
You must be signed in to change notification settings - Fork 0
AURO MIGRATION: Sync templates #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideUpdates the pull request template to introduce a more detailed review checklist, including browser and framework testing requirements, while renaming and restructuring the existing checklist section. Flow diagram for the updated PR review and RC checklist processflowchart TD
A["Start: Author opens PR creation page"] --> B["Read updated 'Review Checklist' section in template"]
B --> C["Confirm update follows 'CONTRIBUTING' guidelines"]
C --> D["Perform self-review of changes"]
D --> E["Expand 'RC Checklist' details section"]
E --> F["Review testing checklist and supporting links"]
F --> G["Perform browser testing on Android (Chrome, Firefox)"]
G --> H["Perform browser testing on iOS (Chrome, Firefox, Safari)"]
H --> I["Perform browser testing on Desktop (Chrome, Firefox, Safari, Edge)"]
I --> J["Validate linked issues with issue reporting team"]
J --> K["Review test coverage report"]
K --> L["Run framework tests using 'Framework playground' (Next React, SvelteKit)"]
L --> M["Mark all applicable checkboxes in the template"]
M --> N["Confirm contribution is under Apache 2.0 license"]
N --> O["Submit Pull Request"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The dev demo link and framework playground URLs are hard-coded to specific Auro resources; consider parameterizing or generalizing these so the template is reusable across different repositories without needing manual edits.
- Within the new RC Checklist, the heading levels and mixed Markdown/HTML (e.g.,
##/###inside<details>plus a trailing<br>) could be simplified for more consistent rendering and accessibility (e.g., avoid the<br>and ensure the heading hierarchy starts at an appropriate level).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The dev demo link and framework playground URLs are hard-coded to specific Auro resources; consider parameterizing or generalizing these so the template is reusable across different repositories without needing manual edits.
- Within the new RC Checklist, the heading levels and mixed Markdown/HTML (e.g., `##`/`###` inside `<details>` plus a trailing `<br>`) could be simplified for more consistent rendering and accessibility (e.g., avoid the `<br>` and ensure the heading hierarchy starts at an appropriate level).
## Individual Comments
### Comment 1
<location> `.github/PULL_REQUEST_TEMPLATE.md:43` </location>
<code_context>
+
+### Scenarios
+
+- [ ] Validated linked issues with issue reporting team
+- [ ] Test coverage report review
+
</code_context>
<issue_to_address>
**suggestion (typo):** Consider adding "the" for smoother grammar in this checklist item.
For example: “Validated linked issues with the issue reporting team.”
```suggestion
- [ ] Validated linked issues with the issue reporting team
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
🚀 PR Release Published! To install: npm install @aurodesignsystem-dev/[email protected]Install via alias: npm install @aurodesignsystem/auro-slideshow@npm:@aurodesignsystem-dev/[email protected] |
66f6830 to
4baa57f
Compare
No description provided.