Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Conversation

@animeavi
Copy link

@animeavi animeavi commented Nov 16, 2022

Fixes #49

image
image

subvod added a commit to subvod/FlipsCygwin that referenced this pull request Mar 24, 2023
subvod added a commit to subvod/FlipsCygwin that referenced this pull request Mar 24, 2023
@subvod
Copy link

subvod commented Mar 25, 2023

Thanks for this. Makes patching expansions a lot less painful.

@Miepee
Copy link
Contributor

Miepee commented May 30, 2024

@Alcaro is there anything specifically that's blocking this PR?

@Alcaro
Copy link
Owner

Alcaro commented May 30, 2024

As mentioned in #49, I'm not a huge fan of this approach, so I don't want to merge it. But it's properly written, and it adds a feature people ask for, so I don't want to reject it just because I'm a cranky lil shit.

That doesn't leave a whole lot of options.

@Miepee
Copy link
Contributor

Miepee commented May 30, 2024

If the point is to protect noobs from shooting themselves in the foot, the GUI label could be changed DANGEROUS: Ignore checksum when patching and/or pop up a dialog box asking the user if they really want to disable them and explain them briefly the consequences.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignore checksum option for bps

4 participants