Use full url path for product link #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fetch products from it in the alchemy-product-select
The version for rails 7.2 and 8.0
This is the version for Rails 7.2 and 8.0
This is the latest release
Convinience for Ruby LSP users
Instead of just using the slug and use a hard coded URL matching, we add a url_path method to the product which returns the full product path instead of just the slug. Add configuration so that this can be changed to something else, if you have custom product urls in your store.
tvdeyen
force-pushed
the
alchemy-8
branch
3 times, most recently
from
d905f3f to
42a3b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #129
Instead of just using the slug and use a hard coded URL matching, we add a
url_pathmethod to the productwhich returns the full product path instead of just the slug.
Add configuration so that this can be changed to
something else, if you have custom product urls in your store.