Add an abstract collection option to the configuration class #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3189 +/- ##
==========================================
- Coverage 96.70% 96.69% -0.01%
==========================================
Files 256 254 -2
Lines 6613 6605 -8
==========================================
- Hits 6395 6387 -8
Misses 218 218 ☔ View full report in Codecov by Sentry. |
mamhoff
force-pushed
the
collection-option
branch
from
72c2cfb to
03df66c
Compare
mamhoff
force-pushed
the
collection-option
branch
2 times, most recently
from
322b702 to
c448f03
Compare
This new class allows us targeted rescuing, so we get good error messages even on collection options.
This option type takes a collection_class and an item_type argument. It is designed to supersede the previous `*_list` classes and wrap any item type with either an Array or a Set. This replaces the previous `StringList`, `IntegerList` and `ClassSet` options.
This serves as an example of a configurable set of classes.
We have a few configurations that are currently arrays of Hashes. This is not type-safe, and sometimes hard to use. This adds a `Alchemy::Configuration::ConfigurationOption` class that can be used with the `CollectionOption` class in `Alchemy::Configuration`. It should not be used as a plain option (we have the `configuration` method for that).
When they share the same name and the same values, they must be the same.
mamhoff
force-pushed
the
collection-option
branch
from
c448f03 to
01e2c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Some of the configurations left in
lib/alchemy.rbare sets ofPathname, or even sets ofConfiguration. This replacement for theInterListOptionandStringListOptioncan deal with any collection of any type.Found the need for this while trying to move the importmap configuration to the new configuration object...
Screenshots
Remove if no visual changes have been made.
Checklist