Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Alchemy's config.yml before app initializers #3229

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 31, 2025

Load Alchemy configuration from YAML files
in config/alchemy/config.yml and config/alchemy/#{Rails.env}.config.yml f they exist.
This has to be done before any app initializers are loaded, so that the configuration is available in all initializers.

@mamhoff mamhoff requested a review from a team as a code owner March 31, 2025 09:45
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (6c8538f) to head (c865f40).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3229   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files         265      265           
  Lines        6720     6720           
=======================================
  Hits         6504     6504           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Load Alchemy configuration from YAML files
in config/alchemy/config.yml and config/alchemy/#{Rails.env}.config.yml
f they exist.
This has to be done before any app initializers are loaded, so that
the configuration is available in all initializers.
@tvdeyen tvdeyen force-pushed the load-yaml-before-initializers branch from 8838cf2 to c865f40 Compare April 1, 2025 10:57
@tvdeyen tvdeyen added this to the 8.0 milestone Apr 1, 2025
@mamhoff mamhoff merged commit 3922ed4 into AlchemyCMS:main Apr 2, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants