Replace tray restore cloak with transition cover - #1225
Closed
MarceloAlejandroJorquera wants to merge 1 commit into
Closed
Replace tray restore cloak with transition cover#1225MarceloAlejandroJorquera wants to merge 1 commit into
MarceloAlejandroJorquera wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
DWMWA_CLOAKworkaround used while restoring MPC-BE from the notification area with a temporary owned layered cover.The existing restore fix rebuilds the frame/view layout after the hidden player is shown, repositions and repaints the renderer, and redraws the complete frame before presenting it. This prevents the white/unpainted client area that could previously appear when restoring from the tray.
The cloak was only being used to prevent DWM from presenting that intermediate restore state.
This change preserves the existing restore/layout fix while removing the cloak.
Implementation
On Windows 8 and later, tray restore now:
The actual restore/layout sequence is otherwise unchanged.
The temporary surface is opaque black and does not capture or reproduce desktop content.
Reason
Keeping the real player cloaked during restore prevents an incomplete frame from being presented, but it also removes the player from DWM presentation while the restore is taking place.
The temporary layered cover provides the same presentation isolation without cloaking the MPC-BE HWND.
The real player can therefore remain normally visible to the window manager while its child layout and renderer destination are finalized behind the independent cover.
Testing
Tested locally with repeated notification-area hide/restore cycles using:
The previous white/unpainted restore-area fix remains effective, and restore works without
DWMWA_CLOAK.This change is limited to the notification-area restore path. Fullscreen transition handling is intentionally outside the scope of this PR.