-
Notifications
You must be signed in to change notification settings - Fork 39
fix lidar mirror issue, taken from linorobot/ldlidar, commit named 'i… #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
as documentation is really rare, collect all available docs and examples
|
Thanks for spotting the issue! |
| float angle = ANGLE_TO_RADIAN(point.angle); | ||
|
|
||
| int index = (int)((angle - output.angle_min) / output.angle_increment); | ||
| int index = (int)((output.angle_max - angle) / output.angle_increment); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation issue
| int index = (int)((output.angle_max - angle) / output.angle_increment); | |
| int index = (int)((output.angle_max - angle) / output.angle_increment); |
|
|
||
| int index = (int)((angle - output.angle_min) / output.angle_increment); | ||
| int index = (int)((output.angle_max - angle) / output.angle_increment); | ||
| // int index = (int)((angle - output.angle_min) / output.angle_increment); //default, but this is inverted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // int index = (int)((angle - output.angle_min) / output.angle_increment); //default, but this is inverted |
no need to keep the commented version
Hello, |
Related to this issue #10
I was able to fix this. The fiy was taken from linorobot/ldlidar repo, which is mostly the same but for ROS2. They also discovered a mirrored laser scan