Add Cromite Android extension support patches to Thorium by abue-ammar · Pull Request #1191 · Alex313031/thorium

abue-ammar · 2026-04-05T10:04:48Z

Summary

Integrate Cromite's Android extension support into Thorium's patch workflow and documentation.

Changes

Added other/enable-extensions-android-thorium.patch adapted from Cromite's experimental Android extension support patch.
Added other/enable-extension-incognito-thorium.patch adapted from Cromite's Android incognito extension support patch.
Updated setup.sh to copy and apply both new patches during patchThor().
Updated docs/PATCHES.md with entries for both newly integrated patches.

Notes

The imported patches remain GPL-2.0-or-later as in the original Cromite sources.
This integrates the feature as Thorium-applied patches; runtime behavior is controlled by the patch content and Chromium/Thorium build/runtime flags.

Validation

bash -n setup.sh
bash -n build_android.sh

Agent-Logs-Url: https://github.com/abue-ammar/thorium/sessions/99abe538-fc80-477b-a14d-c8cb56025629 Co-authored-by: abue-ammar <14371506+abue-ammar@users.noreply.github.com>

…on-patch Add Cromite Android extension support patches to Thorium setup

gz83 · 2026-04-05T10:13:07Z

Thank you for your contribution. Have you compiled and tested it? Also, Cromite's version is higher than Thorium's, so I think it's highly unlikely that Thorium can directly apply this patch.

gz83

I'll set it to -1 for now, until it's fully compiled, tested, and reviewed.

abue-ammar · 2026-04-05T10:29:21Z

Thank you for your contribution. Have you compiled and tested it? Also, Cromite's version is higher than Thorium's, so I think it's highly unlikely that Thorium can directly apply this patch.

i can confirm it needs chrome v143+. and i haven't compiled it yet because my machine isn't capable

gz83 · 2026-04-05T10:39:06Z

If it's only available on M143+ versions, then Thorium cannot use it yet.

In addition, Cromite is not the only branch that has introduced extensions support for the Android version of Chromium; as far as I know, there should be other branches that have done so as well.

I think further evaluation is needed before reviewing this patch.

@abue-ammar @Alex313031

abue-ammar · 2026-04-05T12:37:28Z

If it's only available on M143+ versions, then Thorium cannot use it yet.

In addition, Cromite is not the only branch that has introduced extensions support for the Android version of Chromium; as far as I know, there should be other branches that have done so as well.

I think further evaluation is needed before reviewing this patch.

@abue-ammar @Alex313031

i do not think there is any other branch attatched to it. the patch actually bypass this for android. source: https://www.androidauthority.com/try-new-chrome-for-android-with-extensions-3569268

and if download and extract v143+ you will see chrome desktop android build and the patch is just bypass that as much i have investigated https://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=AndroidDesktop_arm64%2F

gz83 · 2026-04-05T12:45:56Z

The other branches I mentioned have already been mentioned in Alex313031/Thorium-Android#12 (comment). Including cromite, there should be at least 4 branches with extension support.

Alex holds most of the decision-making power in the Thorium project; we need to wait for him to make the final decision on which path to take.

gz83 · 2026-04-05T12:47:25Z

  - Made by uazo

+Experimental Android Extension Support Patch > https://github.com/uazo/cromite/blob/master/build/patches/Experimental-support-for-extensions-on-Android.patch
+  - Adapted for Thorium from Cromite patch


I think the original author should also be credited here.

gz83 · 2026-04-05T12:47:37Z

+  - Adapted for Thorium from Cromite patch
+
+Enable Extensions in Incognito on Android Patch > https://github.com/uazo/cromite/blob/master/build/patches/Enable-extension-in-incognito.patch
+  - Adapted for Thorium from Cromite patch


gz83 · 2026-04-05T12:52:39Z

+Date: Thu, 6 Nov 2025 13:21:24 +0000
+Subject: Experimental support for extensions on Android
+
+Enable experimental support for extensions in Android.


After quickly reviewing the patch, I believe some code still needs modification, such as cromite->thorium.

Additionally, it's necessary to check whether the compiler likes this patch.

done as well!

gz83 · 2026-04-05T12:55:07Z

 	cp -v other/win_updater.patch ${CR_SRC_DIR}/ &&
 	cp -v other/keyboard_shortcuts.patch ${CR_SRC_DIR}/ &&
 	cp -v other/multi-language-translate.patch ${CR_SRC_DIR}/ &&
+	cp -v other/enable-extensions-android-thorium.patch ${CR_SRC_DIR}/ &&


I believe these two patches should only be applied if --android is passed.

you are right!

fixed put it under copyAndroid() so that when only --android is passed it will be applied

gz83 · 2026-04-05T13:23:37Z

I think user script support should also be implemented as soon as possible if we continue to push for extension support.

Updated author attribution for several patches.

…te refs Agent-Logs-Url: https://github.com/abue-ammar/thorium/sessions/e5eb73d6-f391-4f76-867f-dab18286ca22 Co-authored-by: abue-ammar <14371506+abue-ammar@users.noreply.github.com>

…flow Agent-Logs-Url: https://github.com/abue-ammar/thorium/sessions/e5eb73d6-f391-4f76-867f-dab18286ca22 Co-authored-by: abue-ammar <14371506+abue-ammar@users.noreply.github.com>

…cation Fix Android-only patch application and rename Cromite refs in Thorium patch

abue-ammar · 2026-04-05T16:34:53Z

I think user script support should also be implemented as soon as possible if we continue to push for extension support.

it is possible to add userscript. but for now extension support is very important. i think we should upgrade the chromium version and see how it goes. i think it should be fine since thorium does use some cromite patch.

Zoran-The-Great · 2026-04-06T00:27:09Z

Alex holds most of the decision-making power in the Thorium project; we need to wait for him to make the final decision on which path to take.

Don't hold your breath. It's already heen 3 years...

gz83 · 2026-04-06T00:35:02Z

Thank you for editing your PR, even though it was generated using AI.

Additionally, I think we need to try regenerating the patch based on version M138, or wait until Thorium is based on version M144 LTS before continuing this work.

abue-ammar · 2026-04-06T03:54:18Z

Thank you for editing your PR, even though it was generated using AI.

Additionally, I think we need to try regenerating the patch based on version M138, or wait until Thorium is based on version M144 LTS before continuing this work.

you are welcome

Copilot AI and others added 2 commits April 5, 2026 09:54

feat(android): add cromite extension support patches for thorium setup

82ef8d8

Agent-Logs-Url: https://github.com/abue-ammar/thorium/sessions/99abe538-fc80-477b-a14d-c8cb56025629 Co-authored-by: abue-ammar <14371506+abue-ammar@users.noreply.github.com>

Merge pull request #1 from abue-ammar/copilot/analyze-cromite-extensi…

d2a57b8

…on-patch Add Cromite Android extension support patches to Thorium setup

This was referenced Apr 5, 2026

need uBO (chrome extensions) support Alex313031/Thorium-Android#92

Open

Being able to install extensions Alex313031/Thorium-Android#12

Open

gz83 requested a review from Alex313031 April 5, 2026 10:13

gz83 requested changes Apr 5, 2026

View reviewed changes

abue-ammar and others added 4 commits April 5, 2026 22:04

Change patch author attribution to 'Made by uazo'

5689314

Updated author attribution for several patches.

fix: gate android extension patches behind --android and rename cromi…

7d14bd1

…te refs Agent-Logs-Url: https://github.com/abue-ammar/thorium/sessions/e5eb73d6-f391-4f76-867f-dab18286ca22 Co-authored-by: abue-ammar <14371506+abue-ammar@users.noreply.github.com>

fix: always copy android extension patches before apply in --android …

f91c925

…flow Agent-Logs-Url: https://github.com/abue-ammar/thorium/sessions/e5eb73d6-f391-4f76-867f-dab18286ca22 Co-authored-by: abue-ammar <14371506+abue-ammar@users.noreply.github.com>

Merge pull request #2 from abue-ammar/copilot/fix-thorium-patch-appli…

36458ad

…cation Fix Android-only patch application and rename Cromite refs in Thorium patch

Uh oh!

Conversation

abue-ammar commented Apr 5, 2026

Summary

Changes

Notes

Validation

Uh oh!

gz83 commented Apr 5, 2026

Uh oh!

gz83 left a comment

Choose a reason for hiding this comment

Uh oh!

abue-ammar commented Apr 5, 2026

Uh oh!

gz83 commented Apr 5, 2026

Uh oh!

abue-ammar commented Apr 5, 2026

Uh oh!

gz83 commented Apr 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gz83 commented Apr 5, 2026

Uh oh!

abue-ammar commented Apr 5, 2026

Uh oh!

Zoran-The-Great commented Apr 6, 2026

Uh oh!

gz83 commented Apr 6, 2026

Uh oh!

abue-ammar commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants