Skip to content

Narrow public API and clean up some implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bowbahdoe wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Narrow public API and clean up some implementation #1

bowbahdoe wants to merge 8 commits into from

Conversation

@bowbahdoe
Copy link

@bowbahdoe bowbahdoe commented May 16, 2022 •
edited
Loading

  • Makes most classes final so as to reduce the public api surface of this as a library.
  • Utils only has static methods, so hid its constructor
  • Make SeamCarverBase non-public and abstract
  • Instead of using new Thread directly, use an ExecutorService
  • EnergyType is part of a public api but isn't a public class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bowbahdoe