Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Add dataValue prop to MentionInput for setting content based on data values - Implement reconstructFromDataValue utility to parse dataValue strings into mention chips - Refactor MentionData.value to MentionData.displayValue for API clarity - Add comprehensive dataValue reconstruction logic with overlap handling - Support updating mention labels when options change but values remain same - Enable bi-directional data flow: displayValue for UI, dataValue for programmatic control This solves issue #63 by allowing: - Setting input content based on dataValue (e.g., "user-123 user-456") - Proper data extraction for AI tools and APIs - Mention reconstruction when editing existing content - Handle cases where people have same names but different IDs Breaking changes: - MentionData.value → MentionData.displayValue - MentionInputProps.value → MentionInputProps.displayValue - onChange now provides both displayValue (UI text) and dataValue (data IDs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
Fixes #61 #63
Summary