Skip to content

Window: use acquire-based index to get readyForPresent sem #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mrkol merged 1 commit into from
Oct 13, 2025
Merged

Window: use acquire-based index to get readyForPresent sem #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions etna/source/Window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,6 @@ std::optional<Window::SwapchainImage> Window::acquireNext()
auto available =
currentSwapchain.imageAvailable[presentNo % currentSwapchain.imageAvailable.size()].get();

auto readyForPresent =
currentSwapchain.imageReadyForPresent[presentNo % currentSwapchain.imageReadyForPresent.size()]
.get();

// This blocks on mobile when the swapchain has no available images.
vk::AcquireNextImageInfoKHR info{
.swapchain = currentSwapchain.swapchain.get(),
Expand All @@ -121,6 +117,7 @@ std::optional<Window::SwapchainImage> Window::acquireNext()
ETNA_PANIC("Swapchain element acquisition failed! Error code {}", vk::to_string(res));

auto& element = currentSwapchain.elements[index];
auto readyForPresent = currentSwapchain.imageReadyForPresent[index].get();

// NOTE: Sometimes swapchain returns the same image twice in a row.
// This might break stuff, but I'm not sure how right now.
Expand Down