Fix (wayfire/backend): Fixed unhandled exception (out_of_range) after…#5076
Open
muratyalcin-ce wants to merge 1 commit into
Open
Fix (wayfire/backend): Fixed unhandled exception (out_of_range) after…#5076muratyalcin-ce wants to merge 1 commit into
muratyalcin-ce wants to merge 1 commit into
Conversation
… no valid outputs in unordered_map
Author
|
The patch seems to work regardless of whether or not the preserve-output plugin is loaded in wayfire. Explicitly specifiying an output in waybar's configuration also did not affect the patch negatively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waybar version & Setup Info
Waybar v0.15.0Waybar v05945748 (branch 'master')I am launching waybar using wayfire's autostart plugin.
Explanation of the Bug
Waybar crashes with an unhandled exception after i put my laptop in idle.
After examining the logs, i found an unhandled exception in the backend code of wayfire.
Related logs:
Simply adding a try-catch clause could have unintended side effects, i apologize in advance for my lack of knowledge about the codebase.
The patch seems to work when trying to recreate the bug.
There may be a way where the proper wset might not get set and crash the program with a different unhandled exception.
I unfortunately do not have the hardware to test this with multiple outputs.
Please do point out if there are any faults within my solution as I consider myself rather inexperienced.