feat(hyprland/language): support tooltip-format#5134
Open
cancaries wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds configurable tooltip formatting for the Hyprland language module and documents the new configuration options.
Changes:
- Parse a new
tooltip-formatconfig option in the Hyprland language module. - Set tooltip contents dynamically during
update()using the configured format. - Document
tooltipandtooltip-formatoptions in the module man page.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/modules/hyprland/language.cpp | Reads tooltip-format from config and formats tooltip text during updates |
| include/modules/hyprland/language.hpp | Adds storage for tooltip_format_ |
| man/waybar-hyprland-language.5.scd | Documents new tooltip-related configuration options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+16
| if (config_["tooltip-format"].isString()) { | ||
| tooltip_format_ = config_["tooltip-format"].asString(); | ||
| } |
Comment on lines
+67
to
+72
| auto tooltip = trim(fmt::format(fmt::runtime(tooltip_format_), | ||
| fmt::arg("long", layout_.full_name), | ||
| fmt::arg("short", layout_.short_name), | ||
| fmt::arg("shortDescription", layout_.short_description), | ||
| fmt::arg("variant", layout_.variant))); | ||
| label_.set_tooltip_markup(tooltip); |
Comment on lines
+72
to
+74
| label_.set_tooltip_markup(tooltip); | ||
| } else { | ||
| label_.set_tooltip_markup(layoutName); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tooltip-formatsupport tohyprland/language{short},{shortDescription},{long}, and{variant}replacementsFixes #3693
Testing
git diff --checkNote: I could not run a full local build in this environment because the Linux/GTK/Hyprland build toolchain is unavailable.