Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run docs and format on main #163

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CI: Run docs and format on main #163

wants to merge 1 commit into from

Conversation

AlexvZyl
Copy link
Owner

This is needed since we no longer work with a dev branch.

This is needed since we no longer work with a dev branch
@AlexvZyl AlexvZyl added the Enhancement New feature, request or suggestion label Jan 12, 2025
@AlexvZyl AlexvZyl requested a review from 5-pebbles January 12, 2025 17:24
@AlexvZyl AlexvZyl self-assigned this Jan 12, 2025
Comment on lines 2 to 7

on:
push:
branches: [ "dev" ]
branches: [ "main" ]

jobs:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, assuming it will be able to push to main?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about that...

@5-pebbles
Copy link
Collaborator

I think we should allow people with write access to force push main.

If we are only doing one review, anyone with write access can merge changes anyway (using alt accounts). If we need more people doing reviews, we can find a way to allow them to do so without write access. Then GitHub actions can just force push its changes, which will become more important with the introduction of #161.

@AlexvZyl
Copy link
Owner Author

AlexvZyl commented Jan 15, 2025

Allowing force pushing to main is a big mistake, but I assume you mean allowing people to do a normal push? That is something we can maybe do. I just like having that rule to prevent someone from accidentally pushing to main.

The other thing that could really work, is if we allow pushing to main, and instead work with releases. So people don't pull directly from main, but rather the latest release.

@5-pebbles
Copy link
Collaborator

No idea what I was trying to say in that last message...

I don't think you can add GitHub Actions as an exception to branch protection, but you could add your self, or another account used as a bot.

The action would then push using that account's PAT, if you would like, I could set it up and get a working test repo.

@AlexvZyl
Copy link
Owner Author

Yeah I was also thinking about that. You can give it a shot if you want! 👍

@AlexvZyl AlexvZyl marked this pull request as draft January 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature, request or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants