Change border_style to a more adaptable border_style with options
#174
Conversation
Options: `default`, `bright`, `flat` This brings an additional option to the previous `bright_border` option which could be more tweakable.
|
Could you please provide some screenshots? |
|
Here are a few screenshots of both neotree and cmp plugins with each of the 3 options for
|
|
Didn't check the code but I like the addition :) |
|
Please just check how this interacts with setting stuff like the telescope style. Might break if you set both to different settings. |
|
As far as I've checked, some plugins (like telescope) have a specific setting for their integration for |
There was a problem hiding this comment.
This is what bright looks like for me. Not sure why.
kitty 0.40.0 Terminal Font: FiraCodeNFM-Reg (14pt)
I would also suggest changing telescope.style based on border_style while of course leaving users the option to set telescope.style separately if they so choose.
Apologies for the long wait. I just came back from vacation.
| @@ -156,7 +156,7 @@ function M.get_groups() | |||
| -- TermCursorNC= { } -- cursor in an unfocused terminal | |||
| G.ErrorMsg = { fg = C.error } -- error messages on the command line | |||
| G.VertSplit = { fg = C.border_fg } -- the column separating vertically split windows | |||
| G.WinSeparator = { fg = C.border_fg, bg = C.border_bg } -- the column separating vertically split windows | |||
| G.WinSeparator = { fg = O.border_style == 'bright' and C.white0 or C.black0, bg = C.border_bg } -- the column separating vertically split windows | |||
There was a problem hiding this comment.
It seems to me this change isn't necessary, since border_fg will change based on the border_style already.
The only difference being that when border_style=flat there would be no visible separator between splits, which seems to me at least to fit with the "flat" style.
| C.fg_float_border = options.border_style == 'bright' and C.white0 | ||
| or options.border_style == 'default' and C.black0 | ||
| or options.border_style == 'flat' and C.bg_float_border |
There was a problem hiding this comment.
| C.fg_float_border = options.border_style == 'bright' and C.white0 | |
| or options.border_style == 'default' and C.black0 | |
| or options.border_style == 'flat' and C.bg_float_border | |
| C.fg_float_border = options.border_style == 'flat' and C.bg_float_border or C.border_f |
Options:
default,bright,flatThis brings an additional option to the previous
bright_borderoption which could be more tweakable.