Add telnet_password for ShellE1 and ShellMGW2#1454
Open
xiaodong-lx wants to merge 2 commits into
Open
Conversation
AlexxIT
force-pushed
the
master
branch
3 times, most recently
from
007adde to
a1ab25b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
telnet_passwordin ConfigFlow, only tested onMijia_Hub_V2.It's not safe to set a empty password for root user, Gateway exposes telnet port in the public network, especially in IPv6 network.
README.md
Telnet Password - gateway(
Aqara_Hub_E1orMijia_Hub_V2) telnet password. Password will setup while adding integration(keep field empty if you don't want setup password), or you need change both integration config and password in telnet(passwdorchpasswd) later.Config
Issues
Known issue
If
telnet_passwordis configured and not empty, user can not reconfiguretelnet_passwordto empty, I'm not familiar with Python, maybe you can fix it. :-)