Skip to content

Add state charts as depds#42

Open
Xiaoyan-Li wants to merge 3 commits intomainfrom
addStateChartsAsDepds
Open

Add state charts as depds#42
Xiaoyan-Li wants to merge 3 commits intomainfrom
addStateChartsAsDepds

Conversation

@Xiaoyan-Li
Copy link
Collaborator

Add package StateCharts.jl as weak dependent package of AlgebraicABMs. And also add an example using the state chart of a SIR agent-based model, and with a small world network.

added StateCharts.jl as weak dependencies of AlgebraicABMs.jl, and also add test files and an example of SIR model with statecharts and networks.
@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 59.23077% with 53 lines in your changes missing coverage. Please review.

Project coverage is 77.07%. Comparing base (9288dd9) to head (d55234b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ext/StateChartsInterface.jl 59.23% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   82.92%   77.07%   -5.86%     
==========================================
  Files           7        8       +1     
  Lines         328      458     +130     
==========================================
+ Hits          272      353      +81     
- Misses         56      105      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kris-brown
Copy link
Collaborator

Thanks Xiaoyan, independent of my review, can you increase the code coverage of the tests?

Also it seems to have errored on Julia 1.11 (but not on Julia 1.10) which is interesting. What version do you use when you test on your local machine?

@Xiaoyan-Li
Copy link
Collaborator Author

Thanks Xiaoyan, independent of my review, can you increase the code coverage of the tests?

Also it seems to have errored on Julia 1.11 (but not on Julia 1.10) which is interesting. What version do you use when you test on your local machine?

Hi Kris, I’m currently using Julia 1.10.1 on my local machine. I’ll update to Julia 1.11 and investigate the bug. I will also increase the code coverage of tests. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants