fix: remove type parameters from AbstractMachine#94
Open
slibkind wants to merge 1 commit into
Open
Conversation
slibkind
force-pushed
the
sl/generalize_abstract_machine
branch
from
764a114 to
dbb5168
Compare
slibkind
force-pushed
the
sl/generalize_abstract_machine
branch
from
dbb5168 to
7bf4bd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous iterations assume that a subtype of
AbstractMachineis composed of an eltype, interface, and system. However these are only necessary to a particular type of machine which we renameMachine.By removing the type parameters from
AbstractMachineit becomes a more generic abstract type which need not be composed of an interface and a system.