Skip to content

Add diffusion vs. multifrontal benchmark code + docs - #83

Merged
jpfairbanks merged 7 commits into
mainfrom
itay/ecc-vs-acc
Aug 7, 2026
Merged

Add diffusion vs. multifrontal benchmark code + docs#83
jpfairbanks merged 7 commits into
mainfrom
itay/ecc-vs-acc

Conversation

@Optimax14

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.02262% with 486 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.17%. Comparing base (9326b4c) to head (a083887).

Files with missing lines Patch % Lines
...ularSheavesPlots/src/CoordinationBenchmarkPlots.jl 0.00% 347 Missing ⚠️
src/ControlSheaves/CoordinationProfiling.jl 0.00% 122 Missing ⚠️
src/ControlSheaves/CoordinationBenchmarks.jl 95.90% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   45.19%   45.17%   -0.03%     
==========================================
  Files          67       70       +3     
  Lines        6372     7256     +884     
==========================================
+ Hits         2880     3278     +398     
- Misses       3492     3978     +486     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Optimax14
Optimax14 requested a review from jpfairbanks August 6, 2026 02:43
@jpfairbanks jpfairbanks changed the title Add diffusion (ECC) vs. direct (ACC) benchmark code + docs Add diffusion vs. multifrontal benchmark code + docs Aug 6, 2026
@jpfairbanks

Copy link
Copy Markdown
Member

The HTML tables aren't rendering properly in the build. But otherwise the narrative is really good and thorough.

@jpfairbanks jpfairbanks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the tables and take another pass of editing the text. Will review again then.

@Optimax14

Copy link
Copy Markdown
Contributor Author

Table was in fact not fixed 🥲 it renders locally
Will fix it tomorrow

@jpfairbanks

jpfairbanks commented Aug 6, 2026

Copy link
Copy Markdown
Member

@Optimax14 HTML tables are still broken. I think that you should just use PrettyTables.jl and have them render in a text based format rather than trying to emit HTML that gets inlined by documenter. https://ronisbr.github.io/PrettyTables.jl/dev/man/usage/

@jpfairbanks

Copy link
Copy Markdown
Member

@Optimax14, GHA is back up, but the tables are still broken!

@Optimax14

Copy link
Copy Markdown
Contributor Author

@jpfairbanks Just reran the build, it works! 💪 You saw a stale version of the build, let me know what you think of it now. I will do a run through of editing the text as well to be more focused and have a narrative

@jpfairbanks
jpfairbanks merged commit ca83ac0 into main Aug 7, 2026
18 checks passed
@jpfairbanks
jpfairbanks deleted the itay/ecc-vs-acc branch August 7, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants