Add diffusion vs. multifrontal benchmark code + docs - #83
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 45.19% 45.17% -0.03%
==========================================
Files 67 70 +3
Lines 6372 7256 +884
==========================================
+ Hits 2880 3278 +398
- Misses 3492 3978 +486 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The HTML tables aren't rendering properly in the build. But otherwise the narrative is really good and thorough. |
jpfairbanks
left a comment
There was a problem hiding this comment.
Fix the tables and take another pass of editing the text. Will review again then.
|
Table was in fact not fixed 🥲 it renders locally |
|
@Optimax14 HTML tables are still broken. I think that you should just use PrettyTables.jl and have them render in a text based format rather than trying to emit HTML that gets inlined by documenter. https://ronisbr.github.io/PrettyTables.jl/dev/man/usage/ |
|
@Optimax14, GHA is back up, but the tables are still broken! |
|
@jpfairbanks Just reran the build, it works! 💪 You saw a stale version of the build, let me know what you think of it now. I will do a run through of editing the text as well to be more focused and have a narrative |
No description provided.