Open
Conversation
|
Thanks Matt! I definitely like the idea of small modular files within reason, so this looks good to me! (I'm not authorized to approve this though!) @KevinDCarlson |
Collaborator
KevinDCarlson
left a comment
KevinDCarlson
left a comment
There was a problem hiding this comment.
This looks like an improvement, but is there a good explanation for why we'd be including lots of code files rather than breaking into modules? Just as a matter of convenience? If it's that and modules might come in the future in principle, then I'd be happy to start with this.
Member
Author
|
@KevinDCarlson I think its a better idea to break it into modules. Since DataMigrations has a lot of code I'm new to, I decided to sprint to breaking things down first into files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to factor code into a more modular design where it makes sense.