Reduce method redefinition warning noise in model interface tests#212
Merged
Conversation
Agent-Logs-Url: https://github.com/AlgebraicJulia/GATlab.jl/sessions/f0c4f395-e3c1-4168-9a52-f76fc5499343 Co-authored-by: lukem12345 <70283489+lukem12345@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AlgebraicJulia/GATlab.jl/sessions/f0c4f395-e3c1-4168-9a52-f76fc5499343 Co-authored-by: lukem12345 <70283489+lukem12345@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix method re-definition warnings in test logs
Reduce method redefinition warning noise in model interface tests
May 4, 2026
Member
|
@jpfairbanks If I merge this and #210 then GATlab will be at 0 warnings for docs and tests. LGTY? |
lukem12345
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were passing but emitting ~34 method overwrite warnings, which obscured meaningful new warnings. This PR narrows the warning surface by removing repeated method definitions in
test/models/ModelInterface.jlwithout changing production behavior.Isolate negative
@instancecases by model typeFinSetC′across multiple failure-mode tests with dedicated marker model structs (e.g. missing methods, bad sort labels, wrong signatures).WithModel{FinSetC′}specialization.Decouple monoidal tests from base category test model
FinSetC′Monoidalmodel fixture forThStrictMonCattests.ThCategoryinstance forFinSetC′Monoidalby delegating to the existingFinSetC′category operations.Preserve test intent while avoiding overwrite paths
@test_throws,implements,@withmodel) and adjusted only fixture typing/signatures where needed to validate the same failure modes without redefinition collisions.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/AlgebraicJulia/AlgebraicInterfaces.jl/tarball/28cca88bde1068ccf57f950e639df67975517c25REDACTED, pid is -1(http block)https://api.github.com/repos/JuliaCollections/DataStructures.jl/tarball/4e1fe97fdaed23e9dc21d4d664bea76b65fc50a0REDACTED, pid is -1(http block)https://api.github.com/repos/JuliaCollections/OrderedCollections.jl/tarball/05868e21324cede2207c6f0f466b4bfef6d5e7ee/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaData/Parsers.jl/tarball/5d5e0a78e971354b1c7bff0655d11fdc1b0e12c8/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaGraphics/ColorTypes.jl/tarball/67e11ee83a43eb71ddc950302c53bf33f0690dfe/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaGraphics/Colors.jl/tarball/37ea44092930b1811e666c3bc38065d7d87fcc74/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaIO/JSON.jl/tarball/31e996f0a15c7b280ba9f76636b3ff9e2ae58c9aREDACTED, pid is -1(http block)https://api.github.com/repos/JuliaLang/Compat.jl/tarball/9d8a54ce4b17aa5bdce0ea5c34bc5e7c340d16ad/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/JuliaLang/PrecompileTools.jl/tarball/07a921781cab75691315adc645096ed5e370cb77REDACTED, pid is -1(http block)https://api.github.com/repos/JuliaMath/FixedPointNumbers.jl/tarball/05882d6995ae5c12bb5f36dd2ed3f61c98cbb172REDACTED, pid is -1(http block)https://api.github.com/repos/JuliaPackaging/Preferences.jl/tarball/8b770b60760d4451834fe79dd483e318eee709c4REDACTED, pid is -1(http block)https://api.github.com/repos/JuliaStats/Statistics.jl/tarball/ae3bb1eb3bba077cd276bc5cfc337cc65c3075c0REDACTED, pid is -1(http block)https://api.github.com/repos/KristofferC/Crayons.jl/tarball/249fe38abf76d48563e2f4556bebd215aa317e15/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/jolin-io/StructEquality.jl/tarball/192a9f1de3cfef80ab1a4ba7b150bb0e11ceedcf/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)https://api.github.com/repos/simonster/Reexport.jl/tarball/45e428421666073eab6f2da5c9d310d99bb12f9bREDACTED, pid is -1(http block)https://api.github.com/repos/thautwarm/MLStyle.jl/tarball/bc38dff0548128765760c79eb7388a4b37fae2c8/usr/bin/julia julia --project -e using Pkg; Pkg.test()(http block)pkg.julialang.org/usr/bin/julia julia --project -e using Pkg; Pkg.test()(dns block)If you need me to access, download, or install something from one of these locations, you can either: