Skip to content

Reduce method redefinition warning noise in model interface tests #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukem12345 merged 3 commits into from
May 4, 2026
+31 −14
Merged

Reduce method redefinition warning noise in model interface tests #212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
947a18f
Initial plan
Copilot May 4, 2026
73a9e50
test: isolate model types to avoid overwrite warnings
Copilot May 4, 2026
25c6864
test: eliminate model interface overwrite warning noise
Copilot May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 31 additions & 14 deletions test/models/ModelInterface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ module TestModelInterface
using GATlab, GATlab.Stdlib, Test, StructEquality

@struct_hash_equal struct FinSetC′ end
@struct_hash_equal struct FinSetC′MissingCategoryMethods end
@struct_hash_equal struct FinSetC′MissingCategoryId end
@struct_hash_equal struct FinSetC′WrongCategoryIdType end
@struct_hash_equal struct FinSetC′BadCategorySortLabel end
@struct_hash_equal struct FinSetC′ExtraCategorySortAssignment end

# ThCategory models
###################
Expand All @@ -11,31 +16,31 @@ using GATlab, GATlab.Stdlib, Test, StructEquality
#-------------------------------

# Error if we fail to implement methods
@test_throws ErrorException @eval @instance ThCategory{Int, Vector{Int}} [model::FinSetC′] begin
@test_throws ErrorException @eval @instance ThCategory{Int, Vector{Int}} [model::FinSetC′MissingCategoryMethods] begin
end

# Error: missing `id`
@test_throws ErrorException @eval @instance ThCategory{Int, Vector{Int}} [model::FinSetC′] begin
@test_throws ErrorException @eval @instance ThCategory{Int, Vector{Int}} [model::FinSetC′MissingCategoryId] begin
compose(f::Vector{Int}, g::Vector{Int}) = g[f]
dom(f::Vector{Int}) = length(f)
end

# Error if we don't implement methods with args of of right type (`id`)
@test_throws ErrorException @eval @instance ThCategory{Int, Vector{Int}} [model::FinSetC′] begin
@test_throws ErrorException @eval @instance ThCategory{Int, Vector{Int}} [model::FinSetC′WrongCategoryIdType] begin
id(f::Vector{Int}) = f
compose(f::Vector{Int}, g::Vector{Int}) = g[f]
dom(f::Vector{Int}) = length(f)
end

# Error if we label with nonexistent sorts
@test_throws LoadError @eval @instance ThCategory{Ob=Int, Hume=Vector{Int}} [model::FinSetC′] begin
@test_throws LoadError @eval @instance ThCategory{Ob=Int, InvalidSort=Vector{Int}} [model::FinSetC′BadCategorySortLabel] begin
id(::Int) = error("")
compose(::Vector{Int}, ::Vector{Int}) = error("")
end


# Error if we have superfluous type assignments
@test_throws LoadError @eval @instance ThCategory{Ob=Int, Hom=Vector{Int}, Hom2=Matrix{Int}} [model::FinSetC′] begin
@test_throws LoadError @eval @instance ThCategory{Ob=Int, Hom=Vector{Int}, Hom2=Matrix{Int}} [model::FinSetC′ExtraCategorySortAssignment] begin
id(::Int) = error("")
compose(::Vector{Int}, ::Vector{Int}) = error("")
end
Expand Down Expand Up @@ -91,45 +96,57 @@ using .ThCategory
# Monoidal category models
##########################

@struct_hash_equal struct FinSetC′MissingMonoidalObjectMethods end
@struct_hash_equal struct FinSetC′BadMonoidalHomType end
@struct_hash_equal struct FinSetC′Monoidal end

# Failures to create an instance
#-------------------------------

# Missing `mcompose` on objects (`Int`s)
@test_throws ErrorException @eval @instance ThStrictMonCat{Int, Vector{Int}} [model::FinSetC′] begin
@test_throws ErrorException @eval @instance ThStrictMonCat{Int, Vector{Int}} [model::FinSetC′MissingMonoidalObjectMethods] begin

mcompose(f::Vector{Int}, g::Vector{Int}; context) = [f; g .+ context.B₁]

munit() = 0
end


@test_throws ErrorException @eval @instance ThStrictMonCat{Int, Int} [model::FinSetC′] begin
mcompose(a::Int, b::Int) = a + b
mcompose(f::Int, g::Int; context) = f * g
@test_throws ErrorException @eval @instance ThStrictMonCat{Int, Vector{Int}} [model::FinSetC′BadMonoidalHomType] begin
mcompose(a::String, b::String) = string(a, b)
mcompose(f::Vector{Int}, g::Vector{Int}; context) = [f; g .+ context.B₁]

munit() = 0
end

# Actual instance
#----------------

@instance ThStrictMonCat{Int, Vector{Int}} [model::FinSetC′] begin
@instance ThCategory{Ob=Int, Hom=Vector{Int}} [model::FinSetC′Monoidal] begin
Ob(i::Int) = Ob[FinSetC′()](i)
Hom(f::Vector{Int}, n::Int, m::Int) = Hom[FinSetC′()](f, n, m)
id(m::Int) = id[FinSetC′()](m)
compose(f::Vector{Int}, g::Vector{Int}) = compose[FinSetC′()](f, g)
dom(f::Vector{Int}) = dom[FinSetC′()](f)
end

@instance ThStrictMonCat{Int, Vector{Int}} [model::FinSetC′Monoidal] begin

mcompose(a::Int, b::Int) = a + b
mcompose(f::Vector{Int}, g::Vector{Int}; context) = [f; g .+ context.B₁]

munit() = 0
end

@test implements(FinSetC′(), ThStrictMonCat, [Int, Vector{Int}])
@test implements(FinSetC′Monoidal(), ThStrictMonCat, [Int, Vector{Int}])

# Using the instance
#-------------------

using .ThStrictMonCat

@test mcompose[FinSetC′()](id[FinSetC′()](2), id[FinSetC′()](2); context=(;B₁=2)) ==
id[FinSetC′()](4)
@test mcompose[FinSetC′Monoidal()](id[FinSetC′Monoidal()](2), id[FinSetC′Monoidal()](2); context=(;B₁=2)) ==
id[FinSetC′Monoidal()](4)

# Default (old-style) instance
#-----------------------------
Expand Down Expand Up @@ -178,7 +195,7 @@ g = FinFunction([1,1,1],B,A)
# @test Hom([2,3], A, B) == f
@test_throws ErrorException Hom(f, A, A)

@withmodel FinSetC′() (mcompose, id) begin
@withmodel FinSetC′Monoidal() (mcompose, id) begin
@test mcompose(id(2), id(2); context=(;B₁=2)) == id(4)
end

Expand Down
Loading