Simple theory maps and simple pushouts - #146
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (94.80%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 94.52% 94.80% +0.27%
==========================================
Files 38 38
Lines 2082 2174 +92
==========================================
+ Hits 1968 2061 +93
+ Misses 114 113 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
My thought is that we are going to use the multiple-inheritance branch instead of this, so this should not be merged, is that right @kris-brown? |
|
I imagined them as two different means of doing the same thing - I'd be happy to re-implement this down the line (in case we discover a need for programmatically merging theories), using the underlying implementation in multiple-inheritance, so I think it's fine to put this branch on pause / close the PR for now. |
This adds a new instance of
AbsTheoryMapwhich maps generators to generators, rather than to complex terms. For this kind of map we can easily compute pushouts, which is a matter of renaming.The universal property of these colimits is not yet implemented.
Also, this is all at the
GATdata structure level, rather than the module level.