Skip to content

Simple theory maps and simple pushouts - #146

Draft
kris-brown wants to merge 2 commits into
mainfrom
simplepushout
Draft

Simple theory maps and simple pushouts#146
kris-brown wants to merge 2 commits into
mainfrom
simplepushout

Conversation

@kris-brown

Copy link
Copy Markdown
Collaborator

This adds a new instance of AbsTheoryMap which maps generators to generators, rather than to complex terms. For this kind of map we can easily compute pushouts, which is a matter of renaming.

The universal property of these colimits is not yet implemented.

Also, this is all at the GAT data structure level, rather than the module level.

@codecov

codecov Bot commented Mar 16, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.80%. Comparing base (53c6086) to head (a65ffdf).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/syntax/TheoryMaps.jl 94.33% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (94.80%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   94.52%   94.80%   +0.27%     
==========================================
  Files          38       38              
  Lines        2082     2174      +92     
==========================================
+ Hits         1968     2061      +93     
+ Misses        114      113       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@epatters epatters added the enhancement New feature or request label Mar 16, 2024
@olynch

olynch commented Jul 2, 2024

Copy link
Copy Markdown
Member

My thought is that we are going to use the multiple-inheritance branch instead of this, so this should not be merged, is that right @kris-brown?

@kris-brown

Copy link
Copy Markdown
Collaborator Author

I imagined them as two different means of doing the same thing - I'd be happy to re-implement this down the line (in case we discover a need for programmatically merging theories), using the underlying implementation in multiple-inheritance, so I think it's fine to put this branch on pause / close the PR for now.

@epatters epatters changed the title simple theorymaps and simple pushouts Simple theory maps and simple pushouts Jul 2, 2024
@epatters
epatters marked this pull request as draft July 2, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants