[PWGHF] Patches for first Xic autoencoder study #10813
Conversation
macamerl
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
hahassan7,
jpxrk,
apalasciano and
zhangbiao-phy
as code owners
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#10813
|
Hi @macamerl, Thanks for the development! First of all, let me ping the code owner to see if they have any comments on this implementation. @mfaggin @cterrevo and @phymanshu. Then I only have a few comments, see the review. Then could you also fix magalinter errors since they come from this PR? |
changes to fix megalinter check
changes to fix megalinter checks
Changes to fix the PR checks
|
Hi @macamerl @zhangbiao-phy |
|
Thanks @phymanshu. Yes, I locally checked that the BDT inference has no problem after the changes that I made. The flags "applyMSE" and "applyMinMax" are set false/0 by default. In any case, I will privately send you the config file that I used for the check. |
| if (applyMSE) { | ||
| hfMlXicToPKPiCandidate(outputMSEXicToPKPi, outputMSEXicToPiKP); | ||
| } else { | ||
| hfMlXicToPKPiCandidate(outputMlXicToPKPi, outputMlXicToPiKP); | ||
| } |
There was a problem hiding this comment.
Can you not avoid all the branching and just make the decision once?
|
@macamerl Is there any progress? |
|
Hi, I'm implementing the comment received by @fgrosa . However, we had Italian national holidays as soon as after Easter and I had to replace one of my colleagues for other more urgent tasks of the project. Then, I have slowed down the debugging of the new version. I will give you an update next week. |
|
@macamerl Is there any activity on this? |
|
@vkucera Yes, I implemented the ideas (and small adjustment) in the offline mail in the old O2Physics version. it worked at the beginning of June. Now, I think to see some conflicts btw the onnx versions (see error below). Then, I decide to update my local O2Physics version and to arrive at the point that my branch works again. I also attached an example of the error: "Schema error: Trying to register schema with name Abs (domain: version: 1) from file /local/workspace/DailyBuilds/DailyO2Physics-slc9/daily-tags.uO7Ig4H9DC/SOURCES/onnx/v1.17.0-alice2/v1.17.0-alice2/onnx/defs/math/old.cc line 2729, but it is already registered from file /local/workspace/DailyBuilds/DailyO2Physics-slc9/daily-tags.uO7Ig4H9DC/SOURCES/onnx/v1.17.0-alice2/v1.17.0-alice2/onnx/defs/math/old.cc |
|
@macamerl Your current branch does not show any development. |
|
What do you prefer? You want to close this commit request and open a new one when I solve the error (in the previous comment) in my local branch? |
Please do not open a new PR. Just resolve the conflicts, address the comments and push the commits in your branch to update this PR. |
Minimal changes in XicToPKPi specific files (task and selector) to evaluate the MSE between input (externally scaled) and internal scaled output of autoencoder. At moment, one can not run Autoencoder and BDT at the same time since they competitively fill candidate.mlProbXicToPKPi()[0].