Skip to content

[PWGHF] Add configuration and electron hadron table #10920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vkucera merged 64 commits into from
May 20, 2025
Merged

[PWGHF] Add configuration and electron hadron table #10920

vkucera merged 64 commits into from
May 20, 2025

Conversation

@rashigupt
Copy link
Contributor

@rashigupt rashigupt commented Apr 20, 2025 •
edited
Loading

Add electron and hadron tables for offline event mixing, and include histogram bin setting in the configuration

rashi234 and others added 24 commits February 20, 2025 09:02
@rashi234
add non Hfe selection and correlation
e53aa1b
@rashi234
Add nonHfe withclang
834bbd1
@rashi234
Avoid using hard-coded PDG codes
0046cd5
@rashi234
Renamed constant kETA to kEta for consistent naming convention
5317bf7
@rashigupt
Merge branch 'master' into rashi
5dadad7
@rashigupt
Update ElectronSelectionTable.h
c5a198b 
mergeconfict
@rashigupt
Update electronSelectionWithTpcEmcal.cxx
1b026c4 
Replace KTrue to true
@rashigupt
Update CorrelationTables.h
2bdcd40 
Replace HFEHADRONMCGENPAIR to  HFEHADRONMCPAIR
@rashigupt
Update correlatorHfeHadrons.cxx
2def3b6 
Replace HFEHADRONMCGENPAIR to HFEHADRONMCPAIR
@rashigupt
Update taskCorrelationHfeHadrons.cxx
8254eb0 
Replace HFEHADRONMCGENPAIR to HFEHADRONMCPAIR
@rashigupt
Add ConfigurableAxis
7820621 
add bins in Configurable
@rashigupt
Add ConfigurableAxis
8e42d2c
@rashigupt
Merge branch 'master' into rashi
1bdaf36
@rashigupt
Update correlatorHfeHadrons.cxx
dfdc7b5
@rashigupt
Update electronSelectionWithTpcEmcal.cxx
e19cbdc
@rashigupt
correct O2 intel
6f622b5
@rashigupt
Update electronSelectionWithTpcEmcal.cxx
9bfa536
@rashigupt
Remove Typo error
f300a0d
@rashigupt
change Axis name
ffe5dea
@rashigupt
Add config
d489760 
add bin in config
@rashigupt
Update ElectronSelectionTable.h
050f681 
correct electron table
@rashigupt
Add electrontable
6c4665e
@rashigupt
Add config and add electron and hadron table
8a8f43d
@rashigupt
Add config
ef4d23f
vkucera
vkucera reviewed May 6, 2025
View reviewed changes
PWGHF/HFC/DataModel/CorrelationTables.h Outdated
Comment on lines 503 to 504
DECLARE_SOA_COLUMN(LsPairEHCount, lsPairEHCount, int); //! like sign Pair Electron hadron coorelation
DECLARE_SOA_COLUMN(UlsPairEHCount, ulsPairEHCount, int); //! unLike sign Pair Electron hadron coorelation
Copy link
Collaborator

@vkucera vkucera May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DECLARE_SOA_COLUMN(LsPairEHCount, lsPairEHCount, int); //! like sign Pair Electron hadron coorelation
DECLARE_SOA_COLUMN(UlsPairEHCount, ulsPairEHCount, int); //! unLike sign Pair Electron hadron coorelation
DECLARE_SOA_COLUMN(NPairsLS, nPairsLS, int); //! number of like-sign electron-hadron pairs
DECLARE_SOA_COLUMN(NPairsUS, nPairsUS, int); //! number of unlike-sign electron-hadron pairs

vkucera
vkucera requested changes May 6, 2025
View reviewed changes
vkucera
vkucera requested changes May 7, 2025
View reviewed changes
vkucera
vkucera reviewed May 7, 2025
View reviewed changes
vkucera
vkucera approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rashigupt for addressing the issues.

@rashigupt
Copy link
Contributor Author

rashigupt commented May 12, 2025

Dear Expert,
Kindly check and merge this code.

@vkucera
Copy link
Collaborator

vkucera commented May 13, 2025

@deepathoms Can you please check whether your comments have been addressed?

@alibuild
Copy link
Collaborator

alibuild commented May 13, 2025

Error while checking build/O2Physics/o2 for e0561e4 at 2025-05-13 19:43:

## sw/BUILD/arrow-latest/log
/sw/BUILD/5c423fbe2eb3b52187e935043b0d4602548f9a00/arrow/src_tmp/cpp/src/gandiva/precompiled/arithmetic_ops.cc:18:10: fatal error: 'cmath' file not found
ninja: build stopped: subcommand failed.

Full log here.

@rashigupt
Copy link
Contributor Author

rashigupt commented May 20, 2025

Dear expert, please merge the code.

@vkucera vkucera merged commit 01dd039 into AliceO2Group:master May 20, 2025
16 checks passed
ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025
@rashigupt @rashi234 @ariedel-cern
[PWGHF] Add configuration and electron hadron table (AliceO2Group#10920)
69b8910 
Co-authored-by: Rashi Gupta <[email protected]>
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Jun 11, 2025
@rashigupt @rashi234 @jinhyunni
[PWGHF] Add configuration and electron hadron table (AliceO2Group#10920)
8c68739 
Co-authored-by: Rashi Gupta <[email protected]>
prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request Jun 12, 2025
@rashigupt @rashi234
[PWGHF] Add configuration and electron hadron table (AliceO2Group#10920)
24c0d8a 
Co-authored-by: Rashi Gupta <[email protected]>
ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025
@rashigupt @rashi234
[PWGHF] Add configuration and electron hadron table (AliceO2Group#10920)
643016c 
Co-authored-by: Rashi Gupta <[email protected]>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025
@rashigupt @rashi234 @smaff92
[PWGHF] Add configuration and electron hadron table (AliceO2Group#10920)
3c98449 
Co-authored-by: Rashi Gupta <[email protected]>
alibuild pushed a commit to alibuild/O2Physics that referenced this pull request Aug 11, 2025
@rashigupt @rashi234 @CesarOmarRA
[PWGHF] Add configuration and electron hadron table (AliceO2Group#10920)
c11ccaf 
Co-authored-by: Rashi Gupta <[email protected]>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@rashigupt @rashi234 @jloemker
[PWGHF] Add configuration and electron hadron table (AliceO2Group#10920)
e14da83 
Co-authored-by: Rashi Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@singhra1994 singhra1994 singhra1994 left review comments

@vkucera vkucera vkucera approved these changes

@deepathoms deepathoms deepathoms approved these changes

@apalasciano apalasciano apalasciano approved these changes

@fgrosa fgrosa fgrosa left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rashigupt @alibuild @vkucera @fgrosa @deepathoms @apalasciano @singhra1994 @rashi234