[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creator #10972

Rrantu · 2025-04-24T13:04:44Z

Evaluate the resolution of the particles reconstructed using the KFParticle method.

github-actions · 2025-04-24T13:04:58Z

O2 linter results: ❌ 9 errors, ⚠️ 0 warnings, 🔕 2 disabled

vkucera · 2025-04-24T13:25:19Z

Hi @Rrantu , such a huge PR deserves some comments.

First of all, what is your goal?
Second, why do you need so many variables, new structs, histograms and tables?
Why do you need to do further MC matching?
How much more memory does the extra stuff cost?
Last but not least, fix the issues first, only then make the PR ready.

Rrantu · 2025-04-24T13:50:53Z

Hi @vkucera , I'm trying to check the resolution of the particles reconstructed using the KFParticle method. For this, I need the information saved in runXic0Omegac0Creator function, Therefore, I’ve added a new tree within the runXic0Omegac0Creator function to store these variables.
Because KFParticle reconstruction starts from V0s, my MC matching also needs to begin from V0s. So, I’ve written a new process function to read the new tree and do the MC matching accordingly.
I’m not exactly sure how much memory this will consume, but it should be minimal because the new tree is relatively small.
And for the O2 linter issues, they were not introduced by my changes.

zhangbiao-phy · 2025-04-25T07:06:53Z

hi @Rrantu, Thanks for the implementation! I have a few comments. See the review

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

zhangbiao-phy · 2025-04-25T07:40:45Z

Hi @vkucera , I'm trying to check the resolution of the particles reconstructed using the KFParticle method. For this, I need the information saved in runXic0Omegac0Creator function, Therefore, I’ve added a new tree within the runXic0Omegac0Creator function to store these variables. Because KFParticle reconstruction starts from V0s, my MC matching also needs to begin from V0s. So, I’ve written a new process function to read the new tree and do the MC matching accordingly. I’m not exactly sure how much memory this will consume, but it should be minimal because the new tree is relatively small. And for the O2 linter issues, they were not introduced by my changes.

Hi @Rrantu, Thanks! Please fix the O2 linter issues next time!

alibuild · 2025-04-25T12:41:22Z

Error while checking build/O2Physics/o2 for 3268c45 at 2025-04-25 16:23:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/10972-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:2579:86: error: 'const struct o2::soa::Table<o2::aod::Hash<3036674320>, o2::aod::Hash<295670893>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3036674320>, o2::aod::Hash<295670893>, o2::aod::Hash<2286545062> > >' has no member named 'invMassV0Sig'; did you mean 'invMassV0Err'?
/sw/SOURCES/O2Physics/10972-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:2660:89: error: 'const struct o2::soa::Table<o2::aod::Hash<3036674320>, o2::aod::Hash<295670893>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3036674320>, o2::aod::Hash<295670893>, o2::aod::Hash<2286545062> > >' has no member named 'invMassXiSig'; did you mean 'invMassXiErr'?
/sw/SOURCES/O2Physics/10972-slc9_x86-64/0/PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx:2727:94: error: 'const struct o2::soa::Table<o2::aod::Hash<3036674320>, o2::aod::Hash<295670893>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<3036674320>, o2::aod::Hash<295670893>, o2::aod::Hash<2286545062> > >' has no member named 'invMassXic0Sig'; did you mean 'invMassXic0Err'?
ninja: build stopped: subcommand failed.

Full log here.

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

vkucera · 2025-04-25T15:45:13Z

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

+      registry.add("hV0DauPosXPullVsPt", "x_{PULL} vs. p_{T}", HistType::kTH2D, {{20, 0., 20.}, {4000, -20., 20.}});
+      registry.add("hV0DauPosYPullVsPt", "y_{PULL} vs. p_{T}", HistType::kTH2D, {{20, 0., 20.}, {4000, -20., 20.}});
+      registry.add("hV0DauPosZPullVsPt", "z_{PULL} vs. p_{T}", HistType::kTH2D, {{20, 0., 20.}, {4000, -20., 20.}});


That's a lot of bins. Please evaluate the extra RAM consumption when running.

Thanks for the feedback. I have reduced the number of bins.

Let's see if it runs fine, but please check the extra memory consumption. It's still a lot of bins.

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

Co-authored-by: Vít Kučera <[email protected]>

…hannel template paramete

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

fgrosa

It is OK for me, once the comments of @vkucera are also resolved it can be merged

fgrosa · 2025-04-30T09:09:34Z

@vkucera @Rrantu have all the comments been implemented? Can we merge this?

Rrantu · 2025-04-30T09:24:48Z

@vkucera @Rrantu have all the comments been implemented? Can we merge this?
I believe I’ve addressed all the comments. Please let me know if anything else is needed before merging.

…or (AliceO2Group#10972)

Add KFParticle Quality Assurance

1b4ece9

Rrantu requested review from alibuild, vkucera, fcolamar, fgrosa, fcatalan92, mfaggin, mmazzilli, deepathoms, NicoleBastid, hahassan7, jpxrk, apalasciano and zhangbiao-phy as code owners April 24, 2025 13:04

github-actions bot added pwghf PWG-HF datamodel labels Apr 24, 2025

github-actions bot changed the title ~~Add KFParticle Quality Assurance~~ [PWGHF] Add KFParticle Quality Assurance Apr 24, 2025

vkucera marked this pull request as draft April 24, 2025 13:21

Rrantu marked this pull request as ready for review April 24, 2025 14:15

remove unused variables

13be68f

zhangbiao-phy reviewed Apr 25, 2025

View reviewed changes

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Outdated Show resolved Hide resolved

Simplify variable initialization in candidate loop

ebf2081

zhangbiao-phy previously approved these changes Apr 25, 2025

View reviewed changes

zhangbiao-phy enabled auto-merge (squash) April 25, 2025 07:44

zhangbiao-phy disabled auto-merge April 25, 2025 09:55

Changed the column name to clarify its meaning

3268c45

fix error

7476008

Rrantu requested a review from fgrosa April 25, 2025 15:10

vkucera requested changes Apr 25, 2025

View reviewed changes

Use axis objects and update LOGF levels

1e8bc03

Rrantu requested a review from vkucera April 25, 2025 17:56

vkucera reviewed Apr 25, 2025

View reviewed changes

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Outdated Show resolved Hide resolved

Rrantu and others added 5 commits April 26, 2025 10:29

fix error

a7a8022

Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

6acf1f1

Co-authored-by: Vít Kučera <[email protected]>

remove debug varible and add pt resolution histograms

9d9ecea

Replaced int with aod::hf_cand_xic0_omegac0::DecayType for the decayC…

74e7dfd

…hannel template paramete

Updated following the comments

e5dfc17

vkucera requested changes Apr 26, 2025

View reviewed changes

PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Outdated Show resolved Hide resolved

Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx

5beec9e

fgrosa approved these changes Apr 28, 2025

View reviewed changes

Rrantu requested a review from vkucera April 28, 2025 08:53

vkucera changed the title ~~[PWGHF] Add KFParticle Quality Assurance~~ [PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creator Apr 30, 2025

vkucera approved these changes Apr 30, 2025

View reviewed changes

vkucera merged commit c7aff21 into AliceO2Group:master Apr 30, 2025
18 of 20 checks passed

mfaggin pushed a commit to mfaggin/O2Physics that referenced this pull request Apr 30, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

a3d9a89

…or (AliceO2Group#10972)

bghanley1995 pushed a commit to bghanley1995/O2Physics that referenced this pull request May 5, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

357baf2

…or (AliceO2Group#10972)

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

fcb3d0c

…or (AliceO2Group#10972)

jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request May 11, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

2297a90

…or (AliceO2Group#10972)

prottayCMT pushed a commit to prottayCMT/O2Physics2024 that referenced this pull request May 17, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

c9e054d

…or (AliceO2Group#10972)

ariedel-cern pushed a commit to ariedel-cern/O2Physics that referenced this pull request May 23, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

3d3ec68

…or (AliceO2Group#10972)

ddobrigk pushed a commit to ddobrigk/O2Physics that referenced this pull request Jun 14, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

9167298

…or (AliceO2Group#10972)

smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Jun 17, 2025

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creat…

81d3fca

…or (AliceO2Group#10972)

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creator #10972

[PWGHF] Add KFParticle Quality Assurance in XicToXiPi candidate creator #10972

Uh oh!

Conversation

Rrantu commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Apr 24, 2025

Uh oh!

Rrantu commented Apr 24, 2025

Uh oh!

zhangbiao-phy commented Apr 25, 2025

Uh oh!

Uh oh!

zhangbiao-phy commented Apr 25, 2025

Uh oh!

alibuild commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vkucera Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Rrantu Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

vkucera Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgrosa left a comment

Choose a reason for hiding this comment

Uh oh!

fgrosa commented Apr 30, 2025

Uh oh!

Rrantu commented Apr 30, 2025

Uh oh!

Uh oh!

Uh oh!

Rrantu commented Apr 24, 2025 •

edited

Loading

github-actions bot commented Apr 24, 2025 •

edited

Loading

alibuild commented Apr 25, 2025 •

edited

Loading