Do not crash padding an empty table - #447
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
pad_tables_in_text reformats each table block when it hits the closing marker. Two markers with nothing between them (an empty table) leave the buffer empty, and reformat_table then read lines[0] and raised IndexError. Return early when there are no lines.
Author
|
Hi! Gentle nudge on this one whenever you have some bandwidth. It's a small, self-contained fix ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pad_tables_in_textcrashes withIndexErroron an empty table block:When the closing marker is reached the buffered table lines are handed to
reformat_table, which readslines[0]for the column widths. Two markers with nothing between them leave that buffer empty, so it indexes an empty list. Added an early return for the no-lines case, plus a test.