Skip to content

Add configurable MiniMax regional endpoint - #1237

Open
octo-patch wants to merge 1 commit into
Alishahryar1:mainfrom
octo-patch:octo/20260723-parameter-refresh-recvoWl5yOTRwt
Open

Add configurable MiniMax regional endpoint#1237
octo-patch wants to merge 1 commit into
Alishahryar1:mainfrom
octo-patch:octo/20260723-parameter-refresh-recvoWl5yOTRwt

Conversation

@octo-patch

@octo-patch octo-patch commented Jul 23, 2026

Copy link
Copy Markdown

Reason: parameter-refresh | Add the missing China-region MiniMax OpenAI-compatible endpoint configuration.

Changes:

  • Add MINIMAX_BASE_URL with the global endpoint as the default.
  • Route the configured endpoint through the provider catalog and runtime configuration.
  • Document China-region endpoint setup and add configuration/runtime regression coverage.
  • Bump the package version to 4.13.0 and refresh uv.lock.

Checks:

  • uv run ruff format --check
  • uv run ruff check
  • uv run ty check
  • uv run pytest -q tests/config/test_config.py -k 'minimax_base_url_from_env' tests/providers/test_provider_runtime.py -k 'minimax'
  • uv run pytest -q tests/config/test_env_template.py tests/providers/test_minimax.py tests/contracts/test_admin_provider_manifest.py
  • Secret scan and git diff --check

The full local suite has unrelated host-specific installer/uninstaller failures; all focused checks for this change pass.

Greptile Summary

Adds a configurable regional MiniMax endpoint.

  • Defines MINIMAX_BASE_URL with the existing global endpoint as its default.
  • Routes the configured URL through provider runtime construction.
  • Documents the China-region endpoint and adds focused settings/runtime tests.
  • Bumps the package version to 4.13.0 and refreshes lock metadata.

Confidence Score: 3/5

The PR should not merge until MINIMAX_BASE_URL is exposed through the Admin UI configuration manifest as promised by the documented setup flow.

Runtime propagation works, but users following the primary Admin UI workflow cannot configure the new regional endpoint because the schema addition has no corresponding manifest field.

src/free_claude_code/config/settings.py and src/free_claude_code/config/admin/manifest.py

T-Rex T-Rex Logs

What T-Rex did

  • The focused regression harness was run to test MiniMax Settings, and it verified that MINIMAX_BASE_URL is read from the China endpoint and mapped to the minimax_base_url setting in the Admin manifest.
  • The Admin response was serialized to expose MINIMAX_BASE_URL and the persistence mapping retained the submitted value.
  • The existing focused Admin provider manifest contract suite passed all seven tests.
  • A focused minimax pytest run produced four passing tests, with the exact commands and test names captured in the logs.
  • The endpoint override checks showed that without MINIMAX_BASE_URL the global endpoint is used, and with the China override the configured endpoint is used, with all commands exiting with code 0.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
src/free_claude_code/config/settings.py Adds the MiniMax URL setting, but the corresponding Admin UI manifest field is missing.
src/free_claude_code/config/provider_catalog.py Correctly connects the MiniMax descriptor to the new Settings attribute.
tests/providers/test_provider_runtime.py Covers runtime URL propagation but not Admin UI exposure and persistence.
README.md Correctly documents the regional URL, although the documented Admin UI flow cannot expose the new setting.
uv.lock Refreshes project version metadata without changing dependency versions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  ENV[MINIMAX_BASE_URL] --> SETTINGS[Settings.minimax_base_url]
  SETTINGS --> CATALOG[MiniMax provider descriptor]
  CATALOG --> RUNTIME[Provider runtime config]
  RUNTIME --> API[Configured MiniMax endpoint]
  ADMIN[Admin UI manifest] -. missing field .-> SETTINGS
Loading

Reviews (1): Last reviewed commit: "Add MiniMax regional endpoint configurat..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Comment on lines +50 to +53
minimax_base_url: str = Field(
default=MINIMAX_DEFAULT_BASE,
validation_alias="MINIMAX_BASE_URL",
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 MiniMax setting missing from Admin UI

When a China-region MiniMax user follows the documented Admin UI configuration flow, MINIMAX_BASE_URL has no corresponding manifest field, so the endpoint cannot be displayed, validated, or persisted without manually editing an environment file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant