Add configurable MiniMax regional endpoint - #1237
Open
octo-patch wants to merge 1 commit into
Open
Conversation
Comment on lines
+50
to
+53
| minimax_base_url: str = Field( | ||
| default=MINIMAX_DEFAULT_BASE, | ||
| validation_alias="MINIMAX_BASE_URL", | ||
| ) |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: parameter-refresh | Add the missing China-region MiniMax OpenAI-compatible endpoint configuration.
Changes:
MINIMAX_BASE_URLwith the global endpoint as the default.uv.lock.Checks:
uv run ruff format --checkuv run ruff checkuv run ty checkuv run pytest -q tests/config/test_config.py -k 'minimax_base_url_from_env' tests/providers/test_provider_runtime.py -k 'minimax'uv run pytest -q tests/config/test_env_template.py tests/providers/test_minimax.py tests/contracts/test_admin_provider_manifest.pygit diff --checkThe full local suite has unrelated host-specific installer/uninstaller failures; all focused checks for this change pass.
Greptile Summary
Adds a configurable regional MiniMax endpoint.
MINIMAX_BASE_URLwith the existing global endpoint as its default.Confidence Score: 3/5
The PR should not merge until
MINIMAX_BASE_URLis exposed through the Admin UI configuration manifest as promised by the documented setup flow.Runtime propagation works, but users following the primary Admin UI workflow cannot configure the new regional endpoint because the schema addition has no corresponding manifest field.
src/free_claude_code/config/settings.py and src/free_claude_code/config/admin/manifest.py
What T-Rex did
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR ENV[MINIMAX_BASE_URL] --> SETTINGS[Settings.minimax_base_url] SETTINGS --> CATALOG[MiniMax provider descriptor] CATALOG --> RUNTIME[Provider runtime config] RUNTIME --> API[Configured MiniMax endpoint] ADMIN[Admin UI manifest] -. missing field .-> SETTINGSReviews (1): Last reviewed commit: "Add MiniMax regional endpoint configurat..." | Re-trigger Greptile