refactor(alias): return URL when root has .proxy suffix #8357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
drivers/alias/util.go:120
- [nitpick] Consider adding an inline comment explaining that using common.NoProxyRangeMark (-1) for Concurrency acts as a flag to disable proxy range handling.
Concurrency: common.NoProxyRangeMark,
drivers/alias/driver.go:112
- [nitpick] Consider adding a comment explaining that the .proxy suffix forces args.Redirect to true to support concurrent downloads in proxy mode.
if strings.HasSuffix(root, ".proxy") {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
根目录以
.proxy结尾时返回代理链接可以让crypt、mega等驱动(不返回URL的) 更好的支持并发
路径设置示例：
crypt.proxy:/crypt
mega.proxy:/mega