updating pr comments

Author: rpmcginty

src/aibs_informatics_aws_utils/core.py

@@ -145,15 +145,11 @@ def get_region(region: Optional[str] = None) -> str:
 
 def get_account_id() -> str:
     """Will get the account id from the current credentials/identity"""
-    account = get_caller_identity().get("Account")
-    assert account is not None  # mollify mypy
-    return account
+    return get_caller_identity()["Account"]
 
 
 def get_user_id() -> UserId:
-    user_id = UserId(get_caller_identity()["UserId"])
-    assert user_id is not None  # mollify mypy
-    return user_id
+    return UserId(get_caller_identity()["UserId"])
 
 
 def get_iam_arn() -> IAMArn:

src/aibs_informatics_aws_utils/ecr/core.py

@@ -589,7 +589,7 @@ def get_resource_tags(self) -> List[ResourceTag]:
         return [
             ResourceTag(Key=tag["Key"], Value=tag["Value"])
             for tag in self.client.list_tags_for_resource(resourceArn=self.arn)["tags"]
-            if tag.get("Key") and tag.get("Value")
+            if "Key" in tag and "Value" in tag
         ]
 
     def update_resource_tags(

src/aibs_informatics_aws_utils/efs/core.py

@@ -169,10 +169,8 @@ def list_efs_access_points(
         for fs_id in file_system_ids:
             response = efs.describe_access_points(FileSystemId=fs_id)
             access_points.extend(response["AccessPoints"])
-            while response.get("NextToken"):
-                response = efs.describe_access_points(
-                    FileSystemId=fs_id, NextToken=response["NextToken"]
-                )
+            while next_token := response.get("NextToken"):
+                response = efs.describe_access_points(FileSystemId=fs_id, NextToken=next_token)
                 access_points.extend(response["AccessPoints"])
 
     filtered_access_points: List[AccessPointDescriptionTypeDef] = []