Skip to content

Commit 96098b5

Browse files
authored
Merge pull request #450 from AllenInstitute/dev
Dev
2 parents 8fb69c4 + 1b25848 commit 96098b5

File tree

5 files changed

+99
-107
lines changed

5 files changed

+99
-107
lines changed

.github/workflows/build.yml

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,23 @@ jobs:
2626
ref: ${{ github.ref }}
2727

2828
- name: Set up Python
29-
uses: actions/setup-python@v4
29+
uses: actions/setup-python@v5
3030
with:
31-
python-version: "3.12"
31+
python-version: '3.10.11'
3232

3333
# - name: Upgrading pip
3434
# run: pip install --upgrade pip
3535

36-
- name: Install deps
37-
run: pip install cython numpy==1.26
36+
# - name: Install deps
37+
# run: pip install cython numpy==1.26
3838

3939
- name: Installing package
4040
run: pip install -e .
4141

42-
- name: Installing packages again (this prevents a weird error in cell matching nb)
42+
# Some git-based dependencies (e.g., ophys-nway-matching) in requirements.txt
43+
# are not reliably installed via `pip install -e .` due to setuptools limitations.
44+
# This second install ensures all such dependencies are properly installed.
45+
- name: Installing packages again (to avoid setuptools limitations)
4346
run: pip install -r requirements.txt
4447

4548
- name: Installing build dependencies
@@ -53,6 +56,16 @@ jobs:
5356
- name: Printing environment
5457
run: pip freeze
5558

59+
- name: Testing Embargoed Notebooks
60+
run: |
61+
pytest --nbmake --nbmake-timeout=8000 -n=auto "./docs/embargoed"
62+
rm ./docs/embargoed/*.nwb
63+
64+
- name: Testing Higher-Order Notebooks
65+
run: |
66+
pytest --nbmake --nbmake-timeout=8000 -n=auto "./docs/higher-order" --ignore docs/higher-order/behavioral_state.ipynb
67+
rm ./docs/higher-order/*.nwb
68+
5669
- name: Testing Basics Notebooks
5770
run: |
5871
pytest --nbmake --nbmake-timeout=100000 -n=auto "./docs/basics"
@@ -68,21 +81,11 @@ jobs:
6881
pytest --nbmake --nbmake-timeout=8000 -n=auto "./docs/first-order"
6982
rm ./docs/first-order/*.nwb
7083
71-
- name: Testing Higher-Order Notebooks
72-
run: |
73-
pytest --nbmake --nbmake-timeout=8000 -n=auto "./docs/higher-order"
74-
rm ./docs/higher-order/*.nwb
75-
7684
- name: Testing Project Notebooks
7785
run: |
7886
pytest --nbmake --nbmake-timeout=8000 -n=auto "./docs/projects"
7987
rm ./docs/projects/*.nwb
8088
81-
- name: Testing Embargoed Notebooks
82-
run: |
83-
pytest --nbmake --nbmake-timeout=8000 -n=auto "./docs/embargoed"
84-
rm ./docs/embargoed/*.nwb
85-
8689
- name: Printing log
8790
run: |
8891
git config --global --add safe.directory /__w/openscope_databook/openscope_databook

.github/workflows/test.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,14 @@ jobs:
2121
steps:
2222
- uses: actions/checkout@v3
2323

24+
- name: Set up Python
25+
uses: actions/setup-python@v5
26+
with:
27+
python-version: '3.9.13'
28+
2429
# - name: Upgrading pip
2530
# run: pip install --upgrade pip
2631

27-
- name: Install cython
28-
run: pip install cython numpy==1.26
29-
3032
- name: Installing requirements
3133
run: pip install -r ./requirements.txt
3234

docs/embargoed/cell_matching.ipynb

Lines changed: 26 additions & 57 deletions
Large diffs are not rendered by default.

docs/visualization/visualize_neuropixels_probes.ipynb

Lines changed: 41 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,12 @@
4444
"source": [
4545
"import numpy as np\n",
4646
"\n",
47-
"from ccfwidget import CCFWidget"
47+
"from ccfwidget import CCFWidget\n",
48+
"\n",
49+
"# required because CCFwidgets is not using latest version of collections.abc\n",
50+
"import collections\n",
51+
"import collections.abc\n",
52+
"collections.Sequence = collections.abc.Sequence"
4853
]
4954
},
5055
{
@@ -72,13 +77,6 @@
7277
"execution_count": 4,
7378
"metadata": {},
7479
"outputs": [
75-
{
76-
"name": "stderr",
77-
"output_type": "stream",
78-
"text": [
79-
"A newer version (0.62.2) of dandi/dandi-cli is available. You are using 0.61.2\n"
80-
]
81-
},
8280
{
8381
"name": "stdout",
8482
"output_type": "stream",
@@ -157,31 +155,48 @@
157155
{
158156
"cell_type": "code",
159157
"execution_count": 7,
160-
"metadata": {},
161-
"outputs": [],
158+
"metadata": {
159+
"tags": [
160+
"skip-execution"
161+
]
162+
},
163+
"outputs": [
164+
{
165+
"ename": "",
166+
"evalue": "",
167+
"output_type": "error",
168+
"traceback": [
169+
"\u001b[1;31mThe Kernel crashed while executing code in the current cell or a previous cell. \n",
170+
"\u001b[1;31mPlease review the code in the cell(s) to identify a possible cause of the failure. \n",
171+
"\u001b[1;31mClick <a href='https://aka.ms/vscodeJupyterKernelCrash'>here</a> for more info. \n",
172+
"\u001b[1;31mView Jupyter <a href='command:jupyter.viewOutput'>log</a> for further details."
173+
]
174+
}
175+
],
162176
"source": [
163177
"# the 'markers' parameter will expect an iterable where each point is represented as [x,y,z]\n",
164178
"ccf = CCFWidget(markers=[points])"
165179
]
166180
},
167181
{
168182
"cell_type": "code",
169-
"execution_count": 8,
170-
"metadata": {},
183+
"execution_count": 1,
184+
"metadata": {
185+
"tags": [
186+
"skip-execution"
187+
]
188+
},
171189
"outputs": [
172190
{
173-
"data": {
174-
"application/vnd.jupyter.widget-view+json": {
175-
"model_id": "683c4a818ea14ff69df65c1d0d563866",
176-
"version_major": 2,
177-
"version_minor": 0
178-
},
179-
"text/plain": [
180-
"CCFWidget(children=(VBox(children=(Viewer(background=(0.85, 0.85, 0.85), camera=array([[ 1.3441567e+03, -2.172…"
181-
]
182-
},
183-
"metadata": {},
184-
"output_type": "display_data"
191+
"ename": "NameError",
192+
"evalue": "name 'ccf' is not defined",
193+
"output_type": "error",
194+
"traceback": [
195+
"\u001b[1;31m---------------------------------------------------------------------------\u001b[0m",
196+
"\u001b[1;31mNameError\u001b[0m Traceback (most recent call last)",
197+
"Cell \u001b[1;32mIn[1], line 1\u001b[0m\n\u001b[1;32m----> 1\u001b[0m \u001b[43mccf\u001b[49m\n",
198+
"\u001b[1;31mNameError\u001b[0m: name 'ccf' is not defined"
199+
]
185200
}
186201
],
187202
"source": [
@@ -191,7 +206,7 @@
191206
],
192207
"metadata": {
193208
"kernelspec": {
194-
"display_name": "Python 3 (ipykernel)",
209+
"display_name": "Python 3",
195210
"language": "python",
196211
"name": "python3"
197212
},
@@ -205,7 +220,7 @@
205220
"name": "python",
206221
"nbconvert_exporter": "python",
207222
"pygments_lexer": "ipython3",
208-
"version": "3.10.8"
223+
"version": "3.9.13"
209224
}
210225
},
211226
"nbformat": 4,

requirements.txt

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,31 @@
11
autograd==1.7
22
ccfwidget==0.5.3
33
cebra
4-
cython
54
dandi==0.67.2
65
elephant==1.1.1
76
h5py>=3.8
87
ipympl==0.9.4
98
ipywidgets==7.8.1
109
itkwidgets==0.32.6
1110
jupyter==1.0.0
11+
markupsafe==2.0.1
1212
matplotlib==3.6.2
1313
mpl-interactions==0.22.0
14+
nbmake==1.5.3
1415
neo==0.13.0
15-
numpy==1.26
16+
numcodecs==0.11.0
17+
numpy==1.26.0
1618
nwbwidgets
17-
ophys-nway-matching @ git+https://github.com/AllenInstitute/ophys_nway_matching@545504ab55922717ab623f8ede2c521a60aa1458
19+
ophys-nway-matching @ git+https://github.com/AllenInstitute/ophys_nway_matching.git
1820
pandas==1.5.2
1921
Pillow==11
2022
pynwb==2.6.0
23+
pytest-xdist==3.5.0
2124
quantities==0.14.1
2225
remfile==0.1.10
23-
scikit-image==0.25
24-
scipy==1.15
25-
ssm @ git+https://github.com/lindermanlab/ssm
26+
scikit-image==0.18.3
27+
scipy==1.13.1
28+
# ssm @ git+https://github.com/lindermanlab/ssm
2629
statsmodels==0.14.0
2730
suite2p==0.14
2831
tensortools==0.4

0 commit comments

Comments
 (0)