4489 improve the way allsky is compiled#4492
Merged
Merged
Conversation
It's the only one that did anything with "deps".
rather than in the src/Makefile (which made no sense since it didn't need the packages.
install.sh calls "make -C src ..." directly.
.github/workflows/ci_compile.yml calls "make deps".
Now that ci_compile.yml has been updated, there's no need for "deps" or "all".
Also, only execute "make -C src all" if "make -C src deps" worked
Also: * delete RIGHTPATH code - we'll never get there.
It was only needed with PKGBUILD
Was only needed with PKGBUILD
With the change to ci_compile.yml, everything now compiles.
Not sure why it didn't work - it worked in prior version when part of an "if" statement. Also, replace "../bin" with ALLSKYBIN
"install.sh" knows which files/directories should NOT be pi:pi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.