-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude hadoop dependencies from client-hdfs module #16242
base: master-2.x
Are you sure you want to change the base?
Exclude hadoop dependencies from client-hdfs module #16242
Conversation
Can you please provide some background on why this change is necessary? You can put it in the PR description. |
@dbw9580 I completed the description, please take another look. |
@@ -38,6 +38,7 @@ | |||
<dependency> | |||
<groupId>org.apache.hadoop</groupId> | |||
<artifactId>hadoop-client</artifactId> | |||
<scope>provided</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the quick decision is to shade the hadoop dep on the client side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it cannot work if we relocation the hadoop-client, we should use the hadoop from env.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
What changes are proposed in this pull request?
Alluxio client should not contains hadoop dependencies since user env contains the hadoop dependencies already.
Why are the changes needed?
Mark hadoop dependency as provided scope to exclude from shaded client jar.
Does this PR introduce any user facing changes?