Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude hadoop dependencies from client-hdfs module #16242

Open
wants to merge 3 commits into
base: master-2.x
Choose a base branch
from

Conversation

maobaolong
Copy link
Contributor

@maobaolong maobaolong commented Sep 28, 2022

What changes are proposed in this pull request?

Alluxio client should not contains hadoop dependencies since user env contains the hadoop dependencies already.

Why are the changes needed?

Mark hadoop dependency as provided scope to exclude from shaded client jar.

Does this PR introduce any user facing changes?

  • NO

@dbw9580
Copy link
Contributor

dbw9580 commented Sep 28, 2022

Can you please provide some background on why this change is necessary? You can put it in the PR description.

@jiacheliu3 jiacheliu3 requested a review from yuzhu October 6, 2022 01:49
@maobaolong
Copy link
Contributor Author

@dbw9580 I completed the description, please take another look.

@jiacheliu3 jiacheliu3 requested a review from dbw9580 October 11, 2022 01:10
@@ -38,6 +38,7 @@
<dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client</artifactId>
<scope>provided</scope>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the quick decision is to shade the hadoop dep on the client side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it cannot work if we relocation the hadoop-client, we should use the hadoop from env.

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The PR/Issue does not have recent activities and will be closed automatically label Feb 6, 2023
@github-actions github-actions bot removed the stale The PR/Issue does not have recent activities and will be closed automatically label May 17, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The PR/Issue does not have recent activities and will be closed automatically label Jun 17, 2023
@github-actions github-actions bot removed the stale The PR/Issue does not have recent activities and will be closed automatically label Jun 26, 2024
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The PR/Issue does not have recent activities and will be closed automatically label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
POM Change stale The PR/Issue does not have recent activities and will be closed automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants